'Discard changes?' confirm box does not appear for statements
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to reproduce:

go to a File page e.g. https://commons.wikimedia.beta.wmflabs.org/wiki/File:Tatatatakk6_5.jpg
add/edit/delete any statement
click 'cancel' on the statement panel where you've made the change
EXPECTED: a dialog box asking are you sure you want to discard your changes
ACTUAL: no dialog box, changes discarded

Acceptance Criteria:

as above, but with EXPECTED instead of ACTUAL

Details

	Subject	Repo	Branch	Lines +/-
	Bring back statements cancel confirmation message	mediawiki/extensions/WikibaseMediaInfo	master	+61 -10

Customize query in gerrit

Event Timeline

Cparle created this task.Jul 24 2019, 10:39 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2019, 10:39 AM

Cparle added a project: Structured-Data-Team-Current-Work.Jul 24 2019, 10:39 AM

matthiasmullie claimed this task.Jul 24 2019, 11:51 AM

matthiasmullie moved this task from To Do to Code Review on the Structured-Data-Team-Current-Work board.

Change 525260 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Bring back statements cancel confirmation message

https://gerrit.wikimedia.org/r/525260

gerritbot added a project: Patch-For-Review.Jul 24 2019, 11:51 AM

Change 525260 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Bring back statements cancel confirmation message

https://gerrit.wikimedia.org/r/525260

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).Jul 25 2019, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 25 2019, 11:10 AM

• Ramsey-WMF added a project: SDC-Statements (Other-statements-running).Jul 27 2019, 12:51 AM

• Ramsey-WMF moved this task from To Do to Doing on the Structured Data Engineering board.Jul 27 2019, 12:54 AM

• Ramsey-WMF moved this task from Code Review to Verify on Production on the Structured-Data-Team-Current-Work board.Aug 5 2019, 4:32 PM

Confirmed. tested on production.