Use git commit id as "configuration version" for puppet
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	fgiunchedi
	Jul 24 2019, 11:39 AM

Description

While researching how to reduce puppet alerts noise in T228379: Improve our alerting capabilities (Q1 goal FY19-20) I realized instructing puppet master to use git hash as configuration version (i.e. via config_version if I'm not mistaken). Exporting this value as a metric on hosts will let us e.g. catch hosts not running latest version of puppet.git and track rollouts/deployments in dashboards.

TODO:

verify the version is fine not to be incremental
verify potential source of cardinality explosion, if we're putting the version/tag in a metric

Details

Subject	Repo	Branch	Lines +/-
motd: avoid printing double quotes and fix typo	operations/puppet	production	+2 -2
motd: correct awk format	operations/puppet	production	+1 -1
motd: add the config version to the MOTD	operations/puppet	production	+8 -11
puppet git: add a descriptive config version	operations/puppet	production	+10 -0

Customize query in gerrit

Related Objects

Mentioned Here: T228379: Improve our alerting capabilities (Q1 goal FY19-20)

Event Timeline

fgiunchedi created this task.Jul 24 2019, 11:39 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2019, 11:39 AM

fgiunchedi updated the task description. (Show Details)Jul 24 2019, 4:18 PM

herron triaged this task as Medium priority.Jul 26 2019, 4:29 PM

I think this is a really good idea. further after a bit of investigation i think any arbitrary string can be used. Later versions of the puppet documentation even use git rev-parse as an example command. also r10k has a script in there repo which has the sha1, git server and last git log message as the version

https://github.com/voxpupuli/puppet-r10k/blob/master/files/config_version.sh

fgiunchedi moved this task from Inbox to Up next on the observability board.Aug 5 2019, 2:30 PM

jbond added a project: User-jbond.Oct 30 2019, 5:57 PM

jbond moved this task from Unsorted 💣 to Friday tasks on the User-jbond board.Oct 30 2019, 6:07 PM

Change 547505 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] puppet git: add a descriptive config version

https://gerrit.wikimedia.org/r/547505

Change 547506 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] motd: add the config version to the MOTD

https://gerrit.wikimedia.org/r/547506

jbond moved this task from Friday tasks to Patch for Review on the User-jbond board.Oct 31 2019, 12:08 PM

Change 547505 merged by Jbond:
[operations/puppet@production] puppet git: add a descriptive config version

https://gerrit.wikimedia.org/r/547505

Change 547506 merged by Jbond:
[operations/puppet@production] motd: add the config version to the MOTD

https://gerrit.wikimedia.org/r/547506

Change 548720 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] motd: correct awk format

https://gerrit.wikimedia.org/r/548720

Change 548720 merged by Jbond:
[operations/puppet@production] motd: correct awk format

https://gerrit.wikimedia.org/r/548720

Think this is complete now

Change 548743 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] motd: avoid printing double quotes and fix typo

https://gerrit.wikimedia.org/r/548743

Change 548743 merged by Ema:
[operations/puppet@production] motd: avoid printing double quotes and fix typo