Page MenuHomePhabricator

Unhelpful error message: "Error, edit not saved." (mobile-frontend-editor-error)
Closed, ResolvedPublic


In the #wikipedia-en-help IRC channel an editor asked for help with an error that they received. They provided this screenshot:

The page in question is Draft:Milen Manoj Earath. Apparently they tried to update one of the references; I don't think it's a spam blacklist issue (the target website was an Indian government page). There is no entry in the edit filter log, either.

I can't tell what caused the error and found the error message unhelpful. A more specific message would be beneficial, particularly if it allowed to tell whether this is some sort of temporary glitch and/or whether the editor did something wrong.

Event Timeline

Aklapper renamed this task from Unhelpful error message to Unhelpful error message: "Error, edit not saved." (mobile-frontend-editor-error).Jul 24 2019, 4:45 PM

I don't think this should be considered part of T40638. The problem is not that the message needs rewording; the problem is that the actual error message is not shown.

MobileFrontend needs to show the actual error returned by the API when the edit fails, rather than try to handle all possible cases by itself, since the error message may even be "dynamically" defined on the wiki (for edits prevented by an abuse filter or title blacklist).

JTannerWMF added a subscriber: JTannerWMF.

Our team isn't focused on changes to Wikitext Editor at this time.

Somewhat related: in T229532 we're changing VE to also use the errors from the API (rather than our custom handling in some cases), which should help validate this approach.

In T2T228897, @Huon wrote:

I can't tell what caused the error

This error message is shown when internet connectivity is lost between the time of previewing and publishing.

Yes, I've noticed it as well. For example, editing Cascade protected files and pages. If I try to edit a Cascade protected page and save it, it gives an error message that the edit could not be saved.

Steps to reproduce

  • Go to English Wikipedia main page.
  • Now click on a image, transcluded in the page.
  • If the image is in Wikimedia Commons, there will be a warning in the file page "This page is editable only by administrators because it was transcluded in a Cascade protected page.
  • Now, you'll notice that there is still a edit button present in the page even if you are not an administrator.
  • Then edit the page and try to save it.

Expected result

  • It gives a described warning why the edit couldn't be saved.

Actual result

  • It just says "Your edit could not be saved." without any explanation why it could not be saved whatsoever.

Change 537223 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] mobile.editor.overlay: Use errorformat=html and display all error messages

I have not yet thoroughly tested the patch, there's a long list of cases to check (my experience when implementing a similar change in VE: T229532#5430000). But just to give a representative example, here's the before-and-after for the scenario with cascading protection:


Also, for this particular case, of course the editor would ideally display a warning before you waste your time editing; that's a separate problem and filed as T219848.

Change 537223 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] mobile.editor.overlay: Use errorformat=html and display all error messages

JTannerWMF added a subscriber: marcella.

I think you can close this out @marcella

marcella awarded a token.