Page MenuHomePhabricator

Toolbar dialogs break when JS2 is enabled
Closed, ResolvedPublic

Description

While translating the the "Replace next" message, I was suspecting that it would likely rather mean "Replace this, and proceed to next", which is ususal in such cases, I wanted to verify either.
I could not, because the "Search/Replace" button in the UI extra buttons does nothing but widen the inner border of the edit window. More precisely, it adds 1 unit to the left and bottom borders, 2 units to the top border, and does not alter the left border each time it is clicked. Border color in my case is dark brown.


Version: unspecified
Severity: major
OS: Linux
Platform: Other
URL: http://translatewiki.net/w/i.php?title=MediaWiki:Edittoolbar-tool-replace-button-replaceall/ksh&action=edit&loadgroup=ext-ui-0-all&loadtask=untranslated

Details

Reference
bz20893

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:54 PM
bzimport set Reference to bz20893.

For clarity: do you mean that clicking the button doesn't show the dialog? This works for me in Firefox. Which browser are you using? Do you get any JS errors?

To clarify what "Replace next" does: it finds the next occurrence and replaces it, so it's more like "Find next and replace".

Closing as WORKSFORME. If this is still broken, please provide more details.

I do not remember which browser it was (not IE though, I am certain, I was on a Linux box),
Konqueror and Iceweasel (a Mozilla Firefox clone) are the more likely ones.
I did not get JS errors, else I had reported them.

it finds the next occurrence and replaces
it, so it's more like "Find next and replace

This appears pretty useless to me, because you do not see what is going to happen.

I want the order reversed: Find and mark an occurrence, and when I hit a button (either "no, thanks, show next"
or "Yes, do it, then show next") I want an action taken on the text. Also, I want to see as much as possible of
the surrounding text, which means, place the hit very close to the middle of the edit window for me to inspect.
This kind of behavior could be scheduled for another "search and replace" button, or offered depending on a
parameter in the user preferences, I'd suggest.

Reopening, since it did not work for me.

I am going to add more details asap.

The ui edit window right after klicking the "edit" link

Attached:

iceweasel-ui-editwindow-just-open-JAB2.png (362×826 px, 68 KB)

The ui edit window after 40 klicks on the unlabelled lonely symbol in the lowest row of the header block of the edit window

Attached:

iceweasel-ui-editwindow-after-40-klicks-on-lonely-lower-left-symbol-JAB3.png (626×862 px, 96 KB)

The browsers "Help>About" window telling its name, version, and related informations

As one can see, it was Iceweasel.

Attached:

iceweasel-about-JAB4.png (566×308 px, 48 KB)

I tried the same edit with Konqueror on the same machine - it does not even show the new UI edit window head box.

(In reply to comment #3)

I do not remember which browser it was (not IE though, I am certain, I was on a
Linux box),
Konqueror and Iceweasel (a Mozilla Firefox clone) are the more likely ones.
I did not get JS errors, else I had reported them.

it finds the next occurrence and replaces
it, so it's more like "Find next and replace

This appears pretty useless to me, because you do not see what is going to
happen.

I want the order reversed: Find and mark an occurrence, and when I hit a button
(either "no, thanks, show next"
or "Yes, do it, then show next") I want an action taken on the text. Also, I
want to see as much as possible of
the surrounding text, which means, place the hit very close to the middle of
the edit window for me to inspect.
This kind of behavior could be scheduled for another "search and replace"
button, or offered depending on a
parameter in the user preferences, I'd suggest.

This discussion of having a "Replace" instead of a "Replace next" button is at bug 20919.

(In reply to comment #3)

I do not remember which browser it was (not IE though, I am certain, I was on a
Linux box),
Konqueror and Iceweasel (a Mozilla Firefox clone) are the more likely ones.
I did not get JS errors, else I had reported them.

Turns out there was one after all: $j("#edittoolbar-link-tabs").tabs is not a function

This is caused by translatewiki having JS2 enabled, which the UsabilityInitiative extension currently doesn't work nicely with. I'm sure this makes it a dupe, but I can't find the original; updating summary instead.