Link to 'Mute preferences' should not be shown if there are no preferences
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	dbarratt
	Jul 24 2019, 7:57 PM

Description

Problem
A link to Special:Mute was added in T218270. However, as @dom_walden points out in T218270#5351777 the link is still visable even if there are not mute options available. This results in the error message:

Mute features are unavailable. This might be because: you haven't confirmed your email address or the wiki administrator has disabled email features and/or email blacklist for this wiki.

This is a bad user experience. The link should not be shown if there's nothing the user can do. This is the equivalent to showing links the user does not have access to.

Proposed Solution
Override SpecialPage::userCanExecute() in SpecialMute and ensure that a user has "access" to execute the page. Then ensure that this method is being called before the link is displayed.

We will also need to overrided SpecialPage::checkPermissions() to ensure that the same error is shown (i.e. not an access denied error).

Related Objects

Mentioned In: T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user
Mentioned Here: T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user

Event Timeline

dbarratt created this task.Jul 24 2019, 7:57 PM

Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptJul 24 2019, 7:57 PM

dbarratt updated the task description. (Show Details)Jul 24 2019, 7:59 PM

dbarratt mentioned this in T218270: Mute: Add links to the Tools menu on user pages to mute/unmute user.

If I'm understanding this right, this will not happen for any of WMF wikis but there's a chance this might happen for 3rd-party wikis and that's who we are catering to here. In that light, let's discuss how much effort this is before prioritizing it.

JJMC89 moved this task from Backlog to Other on the MediaWiki-User-management board.Aug 13 2019, 4:57 PM

• Niharika moved this task from Untriaged to Product/Tech backlog on the Anti-Harassment board.Sep 30 2019, 10:32 PM

Override SpecialPage::userCanExecute() in SpecialMute and ensure that a user has "access" to execute the page. Then ensure that this >method is being called before the link is displayed.
We will also need to overrided SpecialPage::checkPermissions() to ensure that the same error is shown (i.e. not an access denied error).

You can also just do the check in SkinTemplate where the link is produced. There are already similar checks.

if ( $this->getUser()->isRegistered() && $this->getConfig()->get( 'EnableSpecialMute' ) ) {
   $nav_urls['mute'] = [ ... ];
}

• Niharika moved this task from Product/Tech backlog to Onboarding Tasks on the Anti-Harassment board.Sep 30 2020, 4:03 PM

Tchanders moved this task from Onboarding Tasks to Product/Tech backlog on the Anti-Harassment board.Feb 1 2021, 1:32 PM

• Niharika added a project: AHT-Roadmap.Apr 15 2021, 1:51 PM

dbarratt unsubscribed.Apr 15 2021, 2:14 PM

• Niharika removed a project: AHT-Roadmap.Apr 29 2021, 5:31 PM

Link to 'Mute preferences' should not be shown if there are no preferencesOpen, Needs TriagePublicActions

Description

Related Objects

Event Timeline

Link to 'Mute preferences' should not be shown if there are no preferences
Open, Needs TriagePublic
Actions