Page MenuHomePhabricator

Abusefilter's block with a "Mobile edit" tag
Open, Needs TriagePublic

Event Timeline

A2093064 created this task.Jul 25 2019, 7:13 AM
Restricted Application added subscribers: Cosine02, Aklapper. · View Herald TranscriptJul 25 2019, 7:13 AM
Daimona added a subscriber: Daimona.

Well, this isn't really a bug. The user is editing from mobile, the AF block happens within the same session, which is again on mobile. The block creates a RC entry, and MobileFrontend correctly recognizes and tags it as "mobile edit".
The real issue here is not having a precise way to identify system users (something like r481601), so MF could avoid tagging the RC if it's for a system user. But aside from that, I'm unsure whether the AF block having the "mobile edit" tag should be considered a bug...

Maybe someone would think that Abusefilter can be controlled by real people.

I think the solution here should be implemented inside MF (and not AF). That's because deciding whether to add a certain tag to the edit of a system user strongly depends on the tag itself. For instance, the PHP7 tag would be fine, while the mobile edit tag could be confusing.
Ideally (as I said above), I believe we should have a way to identify system users, and then MobileFrontend (or any other extension adding this kind of tags) should change its RecentChange_save hook handler and abort it earlier if the user is a system user.

DannyS712 moved this task from Backlog to Change tags on the AbuseFilter board.Thu, Oct 10, 6:31 AM