Page MenuHomePhabricator

Allow to avoid installing HHVM from the mediawiki puppet module and profile
Closed, ResolvedPublic

Description

We will soon remove HHVM everywhere, but in the meantime we have parsoid-php that only runs on php 7.2 and thus servers supporting it will need to be installed without HHVM sooner rather than later.

To this end, make HHVM's installation optional - maybe even absent the files and packages if it's not choosen?

Event Timeline

Joe created this task.Thu, Jul 25, 10:26 AM
Joe moved this task from Backlog to Doing on the serviceops board.Thu, Jul 25, 1:42 PM
Joe triaged this task as High priority.Thu, Jul 25, 1:45 PM
jijiki added a subscriber: jijiki.Thu, Jul 25, 1:46 PM
Anomie removed a subscriber: Anomie.Thu, Jul 25, 2:31 PM
ssastry moved this task from Backlog to Deployment on the Parsoid-PHP board.Thu, Jul 25, 3:41 PM

Change 525584 had a related patch set uploaded (by Giuseppe Lavagetto; owner: Giuseppe Lavagetto):
[operations/puppet@production] mediawiki: allow installing php7 only

https://gerrit.wikimedia.org/r/525584

Change 526132 had a related patch set uploaded (by Effie Mouzeli; owner: Effie Mouzeli):
[operations/puppet@production] WIP: jobrunners: Make jobrunners PHP7 only by default

https://gerrit.wikimedia.org/r/526132

jijiki added a comment.EditedMon, Jul 29, 12:40 PM

Before making changes to profile::mediawiki::common and since we are in the process of removing hhvm from jobrunners/videoscalers (T219148), I think we should also consider the following:

  • How we are going to additionally cleanup after hhvm on current servers? For instance an hhvm_remove: true feature flag would stop and remove hhvm along with stop monitoring it
  • In my opinion for new servers (eg servers running parsoid-php), it makes sense to use PHP7 by default instead of via a feature flag, in which case the respected role will mean that nothing related to HHVM will be installed
Mutante edited subscribers, added: Dzahn; removed: Mutante.Wed, Jul 31, 2:00 AM

Change 525584 merged by Giuseppe Lavagetto:
[operations/puppet@production] mediawiki: allow installing php7 only

https://gerrit.wikimedia.org/r/525584

Mentioned in SAL (#wikimedia-operations) [2019-08-01T07:27:43Z] <_joe_> removing mw1348 from rotation - reimaging for T228976

Script wmf-auto-reimage was launched by oblivian on cumin1001.eqiad.wmnet for hosts:

mw1348.eqiad.wmnet

The log can be found in /var/log/wmf-auto-reimage/201908010734_oblivian_256659_mw1348_eqiad_wmnet.log.

Completed auto-reimage of hosts:

['mw1348.eqiad.wmnet']

Of which those FAILED:

['mw1348.eqiad.wmnet']

Script wmf-auto-reimage was launched by oblivian on cumin1001.eqiad.wmnet for hosts:

mw1348.eqiad.wmnet

The log can be found in /var/log/wmf-auto-reimage/201908010736_oblivian_258027_mw1348_eqiad_wmnet.log.

Completed auto-reimage of hosts:

['mw1348.eqiad.wmnet']

and were ALL successful.

Joe closed this task as Resolved.Thu, Aug 1, 10:11 AM

I tested reimaging one application server and it went flawlessly and it's now running without any trace of HHVM. I'll resolve this ticket.