Page MenuHomePhabricator

Enable language_variants_filter for PCS endpoints
Closed, ResolvedPublic

Description

We want the new PCS endpoints (mobile-html, metadata, media, media-list, references) to actually vary their output for different language variants based on the correct accept-language header used.

This seems to be done already for the summary endpoint[1].

Example:

GET https://sr.wikipedia.org/api/rest_v1/page/mobile-html/Канада
Accept: */*
Cache-Control: no-cache
Accept-Language: sr-el

should provide a different output than

GET https://sr.wikipedia.org/api/rest_v1/page/mobile-html/Канада
Accept: */*
Cache-Control: no-cache
Accept-Language: sr-ec

[1] https://github.com/wikimedia/restbase/blob/master/v1/summary_new.yaml#L21

Event Timeline

bearND created this task.Thu, Jul 25, 9:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Jul 25, 9:13 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-30T21:42:02Z] <ppchelko@deploy1001> Started deploy [restbase/deploy@c7e0e33]: Enable language variants filter for PCS endpoints. T229060

Mentioned in SAL (#wikimedia-operations) [2019-07-30T22:00:43Z] <ppchelko@deploy1001> Finished deploy [restbase/deploy@c7e0e33]: Enable language variants filter for PCS endpoints. T229060 (duration: 18m 40s)

Mentioned in SAL (#wikimedia-operations) [2019-07-30T22:00:56Z] <ppchelko@deploy1001> Started deploy [restbase/deploy@c7e0e33]: Enable language variants filter for PCS endpoints. T229060, take 2, feeds timed out

Mentioned in SAL (#wikimedia-operations) [2019-07-30T22:01:59Z] <ppchelko@deploy1001> Finished deploy [restbase/deploy@c7e0e33]: Enable language variants filter for PCS endpoints. T229060, take 2, feeds timed out (duration: 01m 03s)

The fix has been deployed. Now all PCS endpoints support language variants.

Pchelolo closed this task as Resolved.Tue, Jul 30, 10:03 PM
Pchelolo claimed this task.