Page MenuHomePhabricator
Create Task
Maniphest T229060

Enable language_variants_filter for PCS endpoints
Closed, ResolvedPublic
Actions

Description

We want the new PCS endpoints (mobile-html, metadata, media, media-list, references) to actually vary their output for different language variants based on the correct accept-language header used.

This seems to be done already for the summary endpoint[1].

Example:

GET https://sr.wikipedia.org/api/rest_v1/page/mobile-html/Канада
Accept: */*
Cache-Control: no-cache
Accept-Language: sr-el

should provide a different output than

GET https://sr.wikipedia.org/api/rest_v1/page/mobile-html/Канада
Accept: */*
Cache-Control: no-cache
Accept-Language: sr-ec

[1] https://github.com/wikimedia/restbase/blob/master/v1/summary_new.yaml#L21

Related Objects
Search...

Event Timeline

• bearND created this task.Jul 25 2019, 9:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 25 2019, 9:13 PM
• bearND moved this task from Needs triage to Tracking on the Product-Infrastructure-Team-Backlog-Deprecated board.Jul 25 2019, 9:14 PM
• bearND added a parent task: T229012: zhwiki language variant support for references endpoint.Jul 25 2019, 9:17 PM
• Pchelolo edited projects, added Platform Team Workboards (Clinic Duty Team); removed Services.Jul 25 2019, 9:18 PM
• Pchelolo subscribed.

https://github.com/wikimedia/restbase/pull/1174

• Pchelolo moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Jul 25 2019, 9:19 PM
• Pchelolo moved this task from Waiting for Review to Blocked Externally on the Platform Team Workboards (Clinic Duty Team) board.Jul 29 2019, 11:17 PM
• Pchelolo merged a task: T229247: [Bug] mobile-html output not varying based on accept-language header.Jul 30 2019, 4:12 PM
• Pchelolo mentioned this in T229247: [Bug] mobile-html output not varying based on accept-language header.
• Pchelolo added a subscriber: JoeWalsh.
Stashbot added a comment.Jul 30 2019, 9:42 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-30T21:42:02Z] <ppchelko@deploy1001> Started deploy [restbase/deploy@c7e0e33]: Enable language variants filter for PCS endpoints. T229060

Stashbot added a comment.Jul 30 2019, 10:00 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-30T22:00:43Z] <ppchelko@deploy1001> Finished deploy [restbase/deploy@c7e0e33]: Enable language variants filter for PCS endpoints. T229060 (duration: 18m 40s)

Stashbot added a comment.Jul 30 2019, 10:00 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-30T22:00:56Z] <ppchelko@deploy1001> Started deploy [restbase/deploy@c7e0e33]: Enable language variants filter for PCS endpoints. T229060, take 2, feeds timed out

Stashbot added a comment.Jul 30 2019, 10:02 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-30T22:01:59Z] <ppchelko@deploy1001> Finished deploy [restbase/deploy@c7e0e33]: Enable language variants filter for PCS endpoints. T229060, take 2, feeds timed out (duration: 01m 03s)

• Pchelolo added a comment.Jul 30 2019, 10:03 PM

The fix has been deployed. Now all PCS endpoints support language variants.

• Pchelolo closed this task as Resolved.Jul 30 2019, 10:03 PM
• Pchelolo claimed this task.
WDoranWMF moved this task from Blocked Externally to Done on the Platform Team Workboards (Clinic Duty Team) board.Aug 1 2019, 7:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL