Page MenuHomePhabricator

Don’t use heading elements (<h4>) in Wikibase diffs for coordinates and quantities
Open, Needs TriagePublic

Description

As a tool developer, I want to embed diffs generated by Wikibase in my tool, in order to present an edit to my users.

Problem:
Wikibase wraps coordinate and quantity values in diffs in <h4> elements. On Wikibase pages, this looks fine, due to the stylesheets in effect (I’m not sure if the relevant stylesheets are by Wikibase or general to MediaWiki):

Screenshot_2019-07-26 Difference between revisions of Wikidata Sandbox (Q4115189) - Wikidata.png (333×523 px, 26 KB)

However, when embedded in an external tool a using different set of stylesheets, the heading becomes disturbingly large:

Screenshot_2019-07-26 SpeedPatrolling.png (427×1 px, 34 KB) Screen Shot 2019-07-26 at 00.59.03.png (1×720 px, 96 KB)

Example:

Acceptance criteria:

  • quantity and globe coordinate diffs no longer use heading elements
NOTE: This is mostly a duplicate of T220772, which is the same issue but for time values. (Quantity and globe values were mentioned there, too, but ultimately not included in the fix.)

Event Timeline

Change 703919 had a related patch set uploaded (by Lucas Werkmeister; author: Lucas Werkmeister):

[mediawiki/extensions/Wikibase@master] Don’t use heading elements in Wikibase diffs (part 2)

https://gerrit.wikimedia.org/r/703919

Change 703920 had a related patch set uploaded (by Lucas Werkmeister; author: Lucas Werkmeister):

[mediawiki/extensions/Wikibase@master] Don’t style heading elements in Wikibase diffs

https://gerrit.wikimedia.org/r/703920

Change 703919 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Don’t use heading elements in Wikibase diffs (part 2)

https://gerrit.wikimedia.org/r/703919