Page MenuHomePhabricator

flow dumps broken
Closed, ResolvedPublic0 Story Points

Description

Command and stack trace below:

dumpsgen@snapshot1008:/srv/deployment/dumps/dumps/xmldumps-backup$ /usr/bin/php7.2 /srv/mediawiki/multiversion/MWScript.php extensions/Flow/maintenance/dumpBackup.php --wiki=kabwiki --current --report=1 --output=file:/mnt/dumpsdata/temp/dumpsgen/broken-flow.txt 

[28816e3790c9f56f58a55785] [no req]   Error from line 190 of /srv/mediawiki/php-1.34.0-wmf.15/extensions/Flow/includes/Dump/Exporter.php: Cannot access private property Flow\Search\Iterators\TopicIterator::$orderByUUID
Backtrace:
#0 /srv/mediawiki/php-1.34.0-wmf.15/extensions/Flow/maintenance/dumpBackup.php(92): Flow\Dump\Exporter->dump(BatchRowIterator)
#1 /srv/mediawiki/php-1.34.0-wmf.15/extensions/Flow/maintenance/dumpBackup.php(64): FlowDumpBackup->dump(integer)
#2 /srv/mediawiki/php-1.34.0-wmf.15/maintenance/doMaintenance.php(99): FlowDumpBackup->execute()
#3 /srv/mediawiki/php-1.34.0-wmf.15/extensions/Flow/maintenance/dumpBackup.php(144): require_once(string)
#4 /srv/mediawiki/multiversion/MWScript.php(101): require_once(string)
#5 {main}

Tried them for elwiki, frwiki; same error, same stack trace.

Event Timeline

ArielGlenn triaged this task as High priority.Fri, Jul 26, 2:16 PM
ArielGlenn created this task.
Restricted Application added a project: Growth-Team. · View Herald TranscriptFri, Jul 26, 2:30 PM

Change 525820 had a related patch set uploaded (by ArielGlenn; owner: ArielGlenn):
[mediawiki/extensions/Flow@master] make orderUUID public, as it is needed by other classes for Dumps

https://gerrit.wikimedia.org/r/525820

These dumps need to complete by the end of the month, so we should get the fix in and deployed by the 30th.

Adding @Daimona as the person who did the phan patch, and can correct the fix if something else is more appropriate.

I have tested the above on snapshot1008 for kabwiki and the job completes with normal output.

@ArielGlenn Fix approved. I created the property as private just to play "safe". Weird that phan didn't complain about accessing a private property from outside, and that nothing else caught the issue.

Change 525820 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] make orderUUID public, as it is needed by other classes for Dumps

https://gerrit.wikimedia.org/r/525820

Change 525830 had a related patch set uploaded (by ArielGlenn; owner: ArielGlenn):
[mediawiki/extensions/Flow@wmf/1.34.0-wmf.15] make orderUUID public, as it is needed by other classes for Dumps

https://gerrit.wikimedia.org/r/525830

Change 525830 merged by jenkins-bot:
[mediawiki/extensions/Flow@wmf/1.34.0-wmf.15] make orderUUID public, as it is needed by other classes for Dumps

https://gerrit.wikimedia.org/r/525830

Mentioned in SAL (#wikimedia-operations) [2019-07-26T16:05:04Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.15/extensions/Flow/includes/Search/Iterators/TopicIterator.php: T229114 make orderUUID public, as it is needed by other classes for Dumps (duration: 00m 47s)

The fix looks good but I'll keep this open until one of the big wikis like frwiki completes this step.

ArielGlenn closed this task as Resolved.Sat, Jul 27, 5:28 AM
ArielGlenn claimed this task.

All but two wikis (commons, wikidata) have completed flow dumps successfully, which is good enough for me. Closing.

ArielGlenn moved this task from Backlog to Done on the Dumps-Generation board.Sat, Jul 27, 5:28 AM