Page MenuHomePhabricator
Create Task
Maniphest T229114

flow dumps broken
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

Command and stack trace below:

dumpsgen@snapshot1008:/srv/deployment/dumps/dumps/xmldumps-backup$ /usr/bin/php7.2 /srv/mediawiki/multiversion/MWScript.php extensions/Flow/maintenance/dumpBackup.php --wiki=kabwiki --current --report=1 --output=file:/mnt/dumpsdata/temp/dumpsgen/broken-flow.txt 

[28816e3790c9f56f58a55785] [no req]   Error from line 190 of /srv/mediawiki/php-1.34.0-wmf.15/extensions/Flow/includes/Dump/Exporter.php: Cannot access private property Flow\Search\Iterators\TopicIterator::$orderByUUID
Backtrace:
#0 /srv/mediawiki/php-1.34.0-wmf.15/extensions/Flow/maintenance/dumpBackup.php(92): Flow\Dump\Exporter->dump(BatchRowIterator)
#1 /srv/mediawiki/php-1.34.0-wmf.15/extensions/Flow/maintenance/dumpBackup.php(64): FlowDumpBackup->dump(integer)
#2 /srv/mediawiki/php-1.34.0-wmf.15/maintenance/doMaintenance.php(99): FlowDumpBackup->execute()
#3 /srv/mediawiki/php-1.34.0-wmf.15/extensions/Flow/maintenance/dumpBackup.php(144): require_once(string)
#4 /srv/mediawiki/multiversion/MWScript.php(101): require_once(string)
#5 {main}

Tried them for elwiki, frwiki; same error, same stack trace.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
make orderUUID public, as it is needed by other classes for Dumpsmediawiki/extensions/Flowwmf/1.34.0-wmf.15+1 -1
make orderUUID public, as it is needed by other classes for Dumpsmediawiki/extensions/Flowmaster+1 -1
Customize query in gerrit

Event Timeline

ArielGlenn created this task.Jul 26 2019, 2:16 PM
ArielGlenn triaged this task as High priority.
ArielGlenn added a comment.Jul 26 2019, 2:29 PM

Broken in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Flow/+/495966/ at line 25 (patched) https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Flow/+/495966/20/includes/Search/Iterators/TopicIterator.php, I guess this needs to be "public $orderByUUID = false;"

ArielGlenn added a project: StructuredDiscussions.Jul 26 2019, 2:30 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 26 2019, 2:30 PM
gerritbot added a comment.Jul 26 2019, 2:32 PM

Change 525820 had a related patch set uploaded (by ArielGlenn; owner: ArielGlenn):
[mediawiki/extensions/Flow@master] make orderUUID public, as it is needed by other classes for Dumps

https://gerrit.wikimedia.org/r/525820

gerritbot added a project: Patch-For-Review.Jul 26 2019, 2:32 PM
ArielGlenn added a comment.Jul 26 2019, 2:37 PM

These dumps need to complete by the end of the month, so we should get the fix in and deployed by the 30th.

ArielGlenn added a subscriber: Daimona.Jul 26 2019, 2:38 PM

Adding @Daimona as the person who did the phan patch, and can correct the fix if something else is more appropriate.

ArielGlenn added a comment.Jul 26 2019, 2:48 PM

I have tested the above on snapshot1008 for kabwiki and the job completes with normal output.

Daimona added a comment.Jul 26 2019, 2:59 PM

@ArielGlenn Fix approved. I created the property as private just to play "safe". Weird that phan didn't complain about accessing a private property from outside, and that nothing else caught the issue.

ArielGlenn added a comment.Jul 26 2019, 3:01 PM

@Daimona Thank you!

gerritbot added a comment.Jul 26 2019, 3:23 PM

Change 525820 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] make orderUUID public, as it is needed by other classes for Dumps

https://gerrit.wikimedia.org/r/525820

gerritbot added a comment.Jul 26 2019, 3:23 PM

Change 525830 had a related patch set uploaded (by ArielGlenn; owner: ArielGlenn):
[mediawiki/extensions/Flow@wmf/1.34.0-wmf.15] make orderUUID public, as it is needed by other classes for Dumps

https://gerrit.wikimedia.org/r/525830

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).Jul 26 2019, 4:00 PM
gerritbot added a comment.Jul 26 2019, 4:01 PM

Change 525830 merged by jenkins-bot:
[mediawiki/extensions/Flow@wmf/1.34.0-wmf.15] make orderUUID public, as it is needed by other classes for Dumps

https://gerrit.wikimedia.org/r/525830

Stashbot added a comment.Jul 26 2019, 4:05 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-26T16:05:04Z] <jforrester@deploy1001> Synchronized php-1.34.0-wmf.15/extensions/Flow/includes/Search/Iterators/TopicIterator.php: T229114 make orderUUID public, as it is needed by other classes for Dumps (duration: 00m 47s)

ArielGlenn added a comment.Jul 26 2019, 4:09 PM

The fix looks good but I'll keep this open until one of the big wikis like frwiki completes this step.

Maintenance_bot removed a project: Patch-For-Review.Jul 26 2019, 4:10 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.15; 2019-07-23); removed MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).Jul 26 2019, 5:00 PM
ArielGlenn closed this task as Resolved.Jul 27 2019, 5:28 AM
ArielGlenn claimed this task.

All but two wikis (commons, wikidata) have completed flow dumps successfully, which is good enough for me. Closing.

ArielGlenn moved this task from Backlog to Done on the Dumps-Generation board.Jul 27 2019, 5:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits