Page MenuHomePhabricator
Create Task
Maniphest T229184

"View source" has no icon in mobile view of Timeless
Closed, ResolvedPublic
Actions

Description

Go to a page for which you do not have the edit permission. Instead of seeing an icon, you see the string "View source".

I'm not sure of a good icon for this case.

Details

SubjectRepoBranchLines +/-
Better icons/handling for view source, VE edit linksmediawiki/skins/Timelessmaster+98 -49
Customize query in gerrit

Related Objects

Event Timeline

Izno created this task.Jul 28 2019, 4:37 PM
Isarra subscribed.Jul 28 2019, 6:19 PM

Do the minerva icons for this make sense? Or does it show anything if you can't edit?

Izno added a comment.Jul 28 2019, 7:05 PM

Not really? The Minerva icon for edit is a pen; the Minerva icon for view
source is a pen with a lock in the top right.

Edit (source?) in Timeless is a pair of square brackets, as for a wikitext
internal link.

Izno merged a task: T226126: 'View source' on mobile just shows text instead of icon.Jul 28 2019, 7:15 PM
Izno added a comment.Jul 28 2019, 7:23 PM

T173531: New 'edit source' icon may also be of interest.

Isarra added a comment.Jul 28 2019, 7:24 PM

Ah, thanks. Hmm. This might actually be a use case for a creepy eyeball...

Isarra moved this task from Backlog to In progress, or perhaps should be on the Timeless board.Aug 13 2019, 9:31 PM
gerritbot added a comment.Aug 21 2019, 4:11 PM

Change 531523 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Better icons/handling for view source, VE edit links

https://gerrit.wikimedia.org/r/531523

gerritbot added a project: Patch-For-Review.Aug 21 2019, 4:11 PM
gerritbot added a comment.Aug 23 2019, 8:59 PM

Change 531523 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Better icons/handling for view source, VE edit links

https://gerrit.wikimedia.org/r/531523

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 23 2019, 9:00 PM
Restricted Repository Identity mentioned this in rSKINc337c3008e9c: Update git submodules.Aug 23 2019, 9:01 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 23 2019, 9:10 PM
Isarra closed this task as Resolved.Aug 24 2019, 12:22 AM
Isarra claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL