Page MenuHomePhabricator

"View source" has no icon in mobile view of Timeless
Closed, ResolvedPublic

Description

Go to a page for which you do not have the edit permission. Instead of seeing an icon, you see the string "View source".

I'm not sure of a good icon for this case.

Event Timeline

Izno created this task.Jul 28 2019, 4:37 PM
Isarra added a subscriber: Isarra.Jul 28 2019, 6:19 PM

Do the minerva icons for this make sense? Or does it show anything if you can't edit?

Izno added a comment.Jul 28 2019, 7:05 PM

Not really? The Minerva icon for edit is a pen; the Minerva icon for view
source is a pen with a lock in the top right.

Edit (source?) in Timeless is a pair of square brackets, as for a wikitext
internal link.

Ah, thanks. Hmm. This might actually be a use case for a creepy eyeball...

Change 531523 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Better icons/handling for view source, VE edit links

https://gerrit.wikimedia.org/r/531523

Change 531523 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Better icons/handling for view source, VE edit links

https://gerrit.wikimedia.org/r/531523

Isarra closed this task as Resolved.Aug 24 2019, 12:22 AM
Isarra claimed this task.