Page MenuHomePhabricator
Create Task
Maniphest T229185

ArmchairGM links to the most recent commit don't work in Diffusion
Closed, ResolvedPublic
Actions

Description

rAMGM is the archived legacy ArmchairGM repo (originally published as the wikia-ny branch by Wikia back in 2011), available in codesearch as an unlisted repo at the URL https://codesearch.wmflabs.org/armchairgm/ (because while the repository is an interesting piece of MediaWiki history, it is not and has not been actively developed for over a decade; hence why it's an archived reference).

When you search for something, a string or an expression, that is found in one or more files, the result links will have incorrect URLs like https://phabricator.wikimedia.org/diffusion/AMGM/browse/4886e993011435ec10471022d19146e075b9bdcc/extensions/wikia/DPLforum/DPLforum.php ; the hash is incorrect/wrong/unwanted and instead of that it should simply be master for the links to be correct.

Related Objects

Event Timeline

ashley created this task.Jul 28 2019, 7:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 28 2019, 7:29 PM
Legoktm added a project: Phabricator.Jul 28 2019, 8:08 PM

I think this might be a Phabricator issue, given that https://phabricator.wikimedia.org/rAMGM4886e993011435ec10471022d19146e075b9bdcc does in fact exist, except it says:

Unpublished Commit · Learn More
Repository Importing: This repository is still importing.

Legoktm renamed this task from ArmchairGM repo codesearch: links in results are broken, should point to master instead of a certain (nonexistent) hash to ArmchairGM links to the most recent commit don't work in Diffusion.Jul 28 2019, 8:08 PM
Mainframe98 added subscribers: • mmodell, Mainframe98.Jul 29 2019, 10:38 AM

Then it's probably a duplicate of T196855: Diffusion commits stuck in 'Importing...... @mmodell should know how to fix it.

Aklapper edited projects, added: Diffusion; removed: Phabricator.Jul 31 2019, 12:07 AM
ashley mentioned this in T241319: ArmchairGM repo indexing broken entirely.Dec 22 2019, 12:01 PM
• mmodell added a comment.Jan 3 2020, 9:48 PM

fixed with sudo /srv/phab/phabricator/bin/repository refs AMGM --rebuild

• mmodell closed this task as Resolved.Jan 3 2020, 9:48 PM
• mmodell claimed this task.
• mmodell reopened this task as Open.Jan 3 2020, 9:56 PM
• mmodell removed • mmodell as the assignee of this task.

ok so the commits don't show as importing now, however, the problem still exists with the link in the description. The correct URL should look like this:

https://phabricator.wikimedia.org/diffusion/AMGM/browse/master/extensions/wikia/DPLforum/DPLforum.php;4886e993011435ec10471022d19146e075b9bdcc

Legoktm closed this task as Resolved.Jan 19 2020, 8:05 AM
Legoktm claimed this task.

I think we can basically call this fixed now that armchairgm is indexing from github instead :/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits