Page MenuHomePhabricator

Language::uc/lc return type correctness and perf review
Closed, ResolvedPublic


From @aaron:

In some cases these methods would previously not return strings if passed things like
integers or floats which should be harmless. Note that ord() on an integer or
float internally casts the value to a string to get the first octet code.

Event Timeline

Krinkle created this task.Jul 29 2019, 7:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2019, 7:26 PM

Change 522011 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/core@master] language: optimize uc(), lc(), and (uc|lc)first() and enforce return type

Tagging CPT for interest and possible CR to help while I'm keeping the lights one as one-man show (vacations etc.)

k, I see it now. It didn't merge but it was reviewed with +1.

Krinkle assigned this task to aaron.Oct 4 2019, 3:34 AM
Krinkle edited projects, added Performance-Team; removed Performance-Team (Radar).
Gilles moved this task from Inbox to Doing on the Performance-Team board.Oct 7 2019, 8:00 PM

Change 522011 merged by jenkins-bot:
[mediawiki/core@master] language: optimize uc(), lc(), and (uc|lc)first() and enforce return type

aaron closed this task as Resolved.Jan 13 2020, 9:19 PM