Page MenuHomePhabricator

Consider removing X-Wikimedia-Security-Audit VCL support
Closed, ResolvedPublic

Description

There's a feature in VCL added some 4 years ago to send production traffic to labs for security audits (T72181). I initally thought that the current implementation was broken as there are no backends defined for security_audit in operations/puppet, but it turns out that the definitions are in horizon hieradata. Nonetheless, I wonder whether this feature is still in use or if it can be removed.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ema triaged this task as Medium priority.Jul 30 2019, 10:31 AM
ema renamed this task from Remove X-Wikimedia-Security-Audit VCL support to Consider removing X-Wikimedia-Security-Audit VCL support.Jul 30 2019, 10:37 AM
ema updated the task description. (Show Details)
ema moved this task from Backlog to Caching on the Traffic board.

@dduvall: any reason not to proceed with the removal?

BBlack subscribed.

The swap of Traffic for Traffic-Icebox in this ticket's set of tags was based on a bulk action for all such tickets that haven't been updated in 6 months or more. This does not imply any human judgement about the validity or importance of the task, and is simply the first step in a larger task cleanup effort. Further manual triage and/or requests for updates will happen this month for all such tickets. For more detail, have a look at the extended explanation on the main page of Traffic-Icebox . Thank you!

Change 760520 merged by Ema:

[operations/puppet@production] varnish: remove X-Wikimedia-Security-Audit leftover

https://gerrit.wikimedia.org/r/760520

Resetting inactive assignee

BCornwall claimed this task.
BCornwall subscribed.

This seems to have been resolved. git grep -i X-Wikimedia-Security-Audit in the puppet repo returns nothing and wikitech doesn't suggest any other components that need to be updated. I've updated the [[Caching overview]] wiki page to remove X-Wikimedia-Security-Audit from the functionalities section.