Page MenuHomePhabricator
Create Task
Maniphest T229376

JsonConfig hardcodes an older version of wikimedia-ui-base
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

"wmui-base": "git+https://phabricator.wikimedia.org/diffusion/WMUI/wikimedia-ui-base.git#v0.7.1"

which is then saved to lib/wmui-base.less.

According to https://www.npmjs.com/package/wikimedia-ui-base 0.7.1 was never even published to npm.

I noticed this because it's also breaking LibUp.

Details

SubjectRepoBranchLines +/-
Upgrade wikimedia-ui-base from pre-release version to 0.14.0mediawiki/extensions/JsonConfigmaster+238 -149
Customize query in gerrit

Event Timeline

Legoktm created this task.Jul 30 2019, 10:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2019, 10:16 PM
Jdforrester-WMF claimed this task.Jul 30 2019, 10:25 PM
gerritbot added a comment.Jul 30 2019, 10:30 PM

Change 526550 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/JsonConfig@master] Upgrade wikimedia-ui-base from pre-release version to 0.14.0

https://gerrit.wikimedia.org/r/526550

gerritbot added a project: Patch-For-Review.Jul 30 2019, 10:30 PM
gerritbot added a comment.Jul 31 2019, 9:44 AM

Change 526550 merged by jenkins-bot:
[mediawiki/extensions/JsonConfig@master] Upgrade wikimedia-ui-base from pre-release version to 0.14.0

https://gerrit.wikimedia.org/r/526550

Volker_E closed this task as Resolved.Jul 31 2019, 10:00 AM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.17; 2019-08-06).Jul 31 2019, 10:00 AM
Volker_E removed a project: Patch-For-Review.Jul 31 2019, 10:00 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL