Invert configuration for GrowthExperiments
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kostajh
	Jul 31 2019, 9:14 AM

Description

Motivation: Tasks like T224903: First Selenium automation test for GrowthExperiments extension (Homepage) are currently impossible in our CI setup (see T199939) since our config switches default to having all features (welcome survey, help panel, homepage, etc) off. As noted in T199939#5106064, the alternative would be to make all features in GrowthExperiments available and working by default.

We would then need to revisit the settings in mediawiki-config repo, both for production and beta labs, and ensure that we switch on any features before they are ready. (However IIRC at the moment all features are enabled for all wikis that use GrowthExperiments.)

Going forward, if a wiki wants to use GrowthExperiments but does not want to use e.g. WelcomeSurvey, we need to ensure that our configuration changes the default from true to false.

Details

	Subject	Repo	Branch	Lines +/-
	Invert configuration, defaulting features to "on"	mediawiki/extensions/GrowthExperiments	master	+18 -14

Customize query in gerrit

Related Objects

Mentioned In: T233363: New verification emails unexpectedly enabled on cswiki, kowiki, arwiki, viwiki
T224903: First Selenium automation test for GrowthExperiments extension (Homepage)
Mentioned Here: T218345: Investigate Selenium tests for validating event logging data
T199939: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature
T224903: First Selenium automation test for GrowthExperiments extension (Homepage)

Event Timeline

kostajh created this task.Jul 31 2019, 9:14 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 31 2019, 9:14 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Tgr this might be another good onboarding task to familiarize yourself with the various configuration switches.

kostajh mentioned this in T224903: First Selenium automation test for GrowthExperiments extension (Homepage).Jul 31 2019, 9:16 AM

Change 527103 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] (wip) Invert configuration

https://gerrit.wikimedia.org/r/527103

gerritbot added a project: Patch-For-Review.Aug 1 2019, 1:52 PM

Hey @kostajh @MMiller_WMF and I are having a hard time determining where on the board to put this due to the technical nature of it. If this is something Gergo is going to work on soon, please put it in Upcoming and assign it to him.

We have grooming tomorrow and will determine the priority of this during that meeting.

We have grooming tomorrow and will determine the priority of this during that meeting.

@JTannerWMF was there a decision on this?

Moving to current sprint since I have a patch for review on this anyway. I'd also like to revisit T218345 which this patch would allow us to pursue further.

kostajh moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 20 2019, 2:45 PM

Change 527103 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Invert configuration, defaulting features to "on"

https://gerrit.wikimedia.org/r/527103

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 22 2019, 12:39 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 22 2019, 1:04 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 22 2019, 1:10 PM

Etonkovidova closed this task as Resolved.Sep 5 2019, 10:54 PM

Catrope mentioned this in T233363: New verification emails unexpectedly enabled on cswiki, kowiki, arwiki, viwiki.Sep 19 2019, 8:41 PM