Replace “frameless” term by “quiet” for quiet buttons. Frameless came out of a visual description, while quiet is wider used term in design systems and more appropriate for the context.
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/core | master | +535 -464 | Update OOUI to v0.36.4 | |
| oojs/ui | master | +28 -27 | demos: Replace “frameless” by “quiet” and code examples |
Change 526753 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] demos: Replace “frameless” by “quiet” and code examples
That is on the implementation side, frameless has never been a technical term. If you look into the patch, the framed: false continues to be the code hint besides the quiet description.
Also frameless is only true in normal state as they feature a “frame” in focus state. It's worrisome naming in my and designers opinion and it's not such widely-known term (the option being false-framed) to stick to it in comparison to a more sufficient description.
I think the general problem is this only "fixes" the documentation, and leaves it inconsistent with the code, which will lead to even more confusion. If changing frameless to quiet is correct we should change all the variables too, but that will be much harder.
Another result would be to separate this use case from thumbnails description, which seems like an advantage to me.
Change 526753 merged by jenkins-bot:
[oojs/ui@master] demos: Replace “frameless” by “quiet” and code examples
Change 570418 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.36.4
We should amend the demo to show framed:false everywhere it is used, I've had some people ask me what "quiet" means so I don't think it is clear enough.
Even where we do use it it isn't clear that they are referring to the same property:
"ButtonWidget (quiet, framed: false, icon only)"
This looks like three separate settings.
Removing task assignee due to inactivity, as this open task has been assigned for more than two years. See the email sent to the task assignee on February 06th 2022 (and T295729).
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.
If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.