Maniphest T229570

Create generic MessageBox component
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jakob_WMDE
	Aug 1 2019, 11:37 AM

Tags

Referenced Files

None

Subscribers

Description

This component can be reused in the error message banner, and in AnonEditWarning, and LicenseAgreement. Its interface could look similar to EventEmittingButton, with a type prop for variations.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Introduce generic IconMessageBox component	wikibase/termbox	master	+148 -37

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T219886 Unhappy Editing Paths
		Resolved		• Lea_WMDE	T222884 Report failed save to users
		Resolved		Jakob_WMDE	T229570 Create generic MessageBox component

Event Timeline

Jakob_WMDE created this task.Aug 1 2019, 11:37 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2019, 11:37 AM

Jakob_WMDE claimed this task.Aug 1 2019, 1:19 PM

Jakob_WMDE moved this task from To Do to Doing on the Wikibase-Termbox-Iteration-20 board.

Change 525245 had a related patch set uploaded (by Jakob; owner: Tarrow):
[wikibase/termbox@master] Introduce generic IconMessageBox component

https://gerrit.wikimedia.org/r/525245

gerritbot added a project: Patch-For-Review.Aug 1 2019, 1:36 PM

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase-Termbox-Iteration-20 board.Aug 1 2019, 1:47 PM

Change 525245 merged by jenkins-bot:
[wikibase/termbox@master] Introduce generic IconMessageBox component

https://gerrit.wikimedia.org/r/525245

Jakob_WMDE mentioned this in rWBTB3f3f7f5b97d3: Introduce generic IconMessageBox component.Aug 2 2019, 3:06 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 2 2019, 3:10 PM

Tarrow moved this task from Peer Review to Done on the Wikibase-Termbox-Iteration-20 board.Aug 5 2019, 2:13 PM

Ladsgroup closed this task as Resolved.Oct 23 2019, 11:12 AM