Page MenuHomePhabricator

Ensure responsiveness
Closed, ResolvedPublic

Description

As a user I need a user interface, which is adaptable to my current device. Therefore all field should be fit into the current dialog and have no overflow.
Please see here for the specs.

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : masterbridge: Ensure responsiveness

Event Timeline

Pablo-WMDE added a subscriber: Pablo-WMDE.EditedAug 31 2019, 5:48 AM

This is a (forgotten) subtask of an already closed story. Maybe not individually actionable, but still open. Moved to the column top.

Actually there is a problem on the mobile view. When I look on the Bridge page with my mobile phone the dialog as well as the input field is to big to fit into the screen and it enables scrolling. I verified that on my local instance as well as on beta. Everything above the breakpoint look quite nice.

To append: I guess that's depending on OOUI. I guess we just have to figure out in the first place if we want that behavior or not(@Charlie_WMDE).

from what I can see we do not want that behavior. Mobile is supposed to look like specified in the figma document and this ticket T224833

@Charlie_WMDE - Actually I know, where to fix that, but need more input for that or break-points. If we use breakpoints the input field have the same width as the break-point. The other way around is be by using vw ( https://css-tricks.com/fun-viewport-units/ ), but there could be some problems with mobile browsers (https://caniuse.com/#search=vw).

Pablo-WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-4 board.

Change 535603 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: Ensure responsiveness

https://gerrit.wikimedia.org/r/535603

Change 535603 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Ensure responsiveness

https://gerrit.wikimedia.org/r/535603

Please add a task description so we actually know what to verify :)

yay \o/ looks good from my side

@Matthias_Geisler_WMDE quick questions that shouldn't hinder the closing of this ticket: is there a way to restrict how small the modal can get? What i mean is that when the viewport becomes a certain size, we stop shrinking the modal to fit but just have it be outside of the viewport (which would then need a scrollbar).

@Charlie_WMDE I think it should be possible in general, but I also think we should take a closer look where we do that (ooui?, in our part?) and that would worth it's own task.

oky doke. then i'll make us a placeholder ticket in the backlog for that. thanks!

Lydia_Pintscher closed this task as Resolved.Sep 17 2019, 5:44 PM
Lydia_Pintscher moved this task from Verification to Done on the Wikidata-Bridge-Sprint-5 board.

\o/