When installer fails, an extra message is shown: Service disabled: DBLoadBalancerFactory while CLI installation failed
Closed, ResolvedPublic
Actions

Description

After T46511 resolved, when the CLI installation failed, the script output:

Wikimedia\Services\ServiceDisabledException from line 417 of includes\libs\services\ServiceContainer.php: Service disabled: DBLoadBalancerFactory
Backtrace:
#0 includes\MediaWikiServices.php(563): Wikimedia\Services\ServiceContainer->getService(string)
#1 maintenance\doMaintenance.php(123): MediaWiki\MediaWikiServices->getDBLoadBalancerFactory()
#2 maintenance\install.php(193): require_once(string)
#3 {main}

This is expected. because the installation script will disable all storage layer services at the beginning (via MediaWikiServices::disableStorageBackend() called by Installer::__construct()), if the installation is successful, these services will be restored, but if the installation is not successful, this state will enter this if-block.

# maintenance/doMaintenance.php
if ( $maintenance->getDbType() !== Maintenance::DB_NONE ) {
	// Perform deferred updates.
	$lbFactory = MediaWikiServices::getInstance()->getDBLoadBalancerFactory(); // fatal, the service is disabled.
	$lbFactory->commitMasterChanges( $maintClass );
	DeferredUpdates::doUpdates();
}

If the installation fails, we have no need/cannot commit the master changes.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	REL1_34	+4 -1	Make sure DBLoadBalancerFactory service is not disabled
	mediawiki/core	master	+4 -1	Make sure DBLoadBalancerFactory service is not disabled

Customize query in gerrit

Related Objects

Mentioned In: T232413: mwext-php72-phan-docker job fails on WikimediaMessages: A dependency error was encountered while installing the extension "MinervaNeue": Could not find the registration file for the extension "MobileFrontend"
T225512: install.php --with-extensions silently ignores extensions whose dependencies are not satisfied
T231876: All CI failing with “Service disabled: DBLoadBalancerFactory”
Mentioned Here: T46511: Installer aborts on outdated sqlite module though "--dbtype mysql" was passed

Event Timeline

RazeSoldier created this task.Aug 1 2019, 5:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2019, 5:33 PM

RazeSoldier updated the task description. (Show Details)Aug 1 2019, 5:45 PM

RazeSoldier added a project: MW-1.34-release.Aug 14 2019, 3:38 PM

Pablo-WMDE mentioned this in T231876: All CI failing with “Service disabled: DBLoadBalancerFactory”.Sep 3 2019, 2:14 PM

Hey there, should this be moved to 1.35? The cut is a couple of weeks away. If it needs to go out in 1.34, is there anything I can do to help get it out of the door?

In T229601#5469783, @Jdforrester-WMF wrote:

Hey there, should this be moved to 1.35? The cut is a couple of weeks away. If it needs to go out in 1.34, is there anything I can do to help get it out of the door?

This error has no major impact. It only occurs when the installation fails, but it can cause noise to the end user.

RazeSoldier mentioned this in T225512: install.php --with-extensions silently ignores extensions whose dependencies are not satisfied.Sep 10 2019, 12:05 AM

Krinkle mentioned this in T232413: mwext-php72-phan-docker job fails on WikimediaMessages: A dependency error was encountered while installing the extension "MinervaNeue": Could not find the registration file for the extension "MobileFrontend".Sep 10 2019, 12:48 AM

In T229601#5469783, @Jdforrester-WMF wrote:

Hey there, should this be moved to 1.35? The cut is a couple of weeks away. If it needs to go out in 1.34, is there anything I can do to help get it out of the door?

The fix should be trivial, if we can decide on the best approach. Would be nice to get it into 1.34, as it's confusing to the end user. When the installer fails, this generates a lot of noise, suggesting that it is the cause of the problem, while really it's just a side effect.

My suggestion would be to skip the above mentioned block if the storage backend is disabled. Would be nice to issue a warning if there are pending updates that get ignored.

Change 539141 had a related patch set uploaded (by 星耀晨曦; owner: 星耀晨曦):
[mediawiki/core@master] Make sure DBLoadBalancerFactory service is not disabled

https://gerrit.wikimedia.org/r/539141

gerritbot added a project: Patch-For-Review.Sep 25 2019, 3:30 PM

I am trying to advance this ticket.

RazeSoldier added a comment.Sep 25 2019, 3:32 PM

This comment was removed by RazeSoldier.

RazeSoldier claimed this task.Sep 25 2019, 3:49 PM

hashar renamed this task from Service disabled: DBLoadBalancerFactory while CLI installation failed to When installer fails, an extra message is shown: Service disabled: DBLoadBalancerFactory while CLI installation failed.Oct 7 2019, 9:25 AM

hashar triaged this task as Medium priority.

In T229601#5522996, @gerritbot wrote:

[mediawiki/core@master] Make sure DBLoadBalancerFactory service is not disabled

https://gerrit.wikimedia.org/r/539141

This patch is nominated for 1.34 but requires code review. Given involvement from Daniel and CPT's previous interest in the installer, tagging CPT for possible CR.

I'll leave it for another time to ask whether this should be made official on mw:Maintainers so that these aren't unattended for so long in the future. (That is, to make official that CPT is or is not the steward, so that if not, we can start looking for a steward elsewhere in the org).

Anomie edited projects, added Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.Nov 6 2019, 3:52 PM

Anomie moved this task from Inbox to External Code Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.Nov 6 2019, 3:59 PM

Change 539141 merged by jenkins-bot:
[mediawiki/core@master] Make sure DBLoadBalancerFactory service is not disabled

https://gerrit.wikimedia.org/r/539141

(still needs backport to 1.34 though)

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 6 2019, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 6 2019, 5:11 PM

Change 549117 had a related patch set uploaded (by 星耀晨曦; owner: 星耀晨曦):
[mediawiki/core@REL1_34] Make sure DBLoadBalancerFactory service is not disabled

https://gerrit.wikimedia.org/r/549117

gerritbot added a project: Patch-For-Review.Nov 6 2019, 5:12 PM

Reopen as a backport patch haven't not merge yet .

CCicalese_WMF moved this task from External Code Review Completed to External Code Review Needed on the Core Platform Team Workboards (Clinic Duty Team) board.Nov 23 2019, 4:37 AM