Page MenuHomePhabricator

CentralAuth tests are broken
Closed, ResolvedPublic


All tests on mediawiki/extensions/CentralAuth are failing.

19:33:41 <?xml version="1.0" encoding="ISO-8859-15"?>
19:33:41 <checkstyle version="6.5">
19:33:41   <file name="maintenance/deleteLocalPasswords.php">
19:33:41     <error line="61" severity="warning" message="Returning type \Wikimedia\Rdbms\DBConnRef but getUserDB() is declared to return \Wikimedia\Rdbms\IMaintainableDatabase" source="PhanTypeMismatchReturn"/>
19:33:41   </file>
19:33:41 </checkstyle>

See and as an example.

Event Timeline

Urbanecm triaged this task as High priority.Aug 1 2019, 7:39 PM

Breaks all work on extension => at least high, if not UBN.

Jdforrester-WMF added a subscriber: Jdforrester-WMF.

This is just the phan breakage for dozens of repos, right?

CentralAuth isn't in the gate so this isn't a shared build failure.

Change 527630 had a related patch set uploaded (by Jforrester; owner: Dbarratt):
[mediawiki/extensions/CentralAuth@master] Bust the database connection cache.

Change 527630 abandoned by Dbarratt:
Bust the database connection cache.