CentralAuth tests are broken
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Urbanecm
	Aug 1 2019, 7:39 PM

Project Tags

Referenced Files

None

Subscribers

Description

All tests on mediawiki/extensions/CentralAuth are failing.

19:33:41 <?xml version="1.0" encoding="ISO-8859-15"?>
19:33:41 <checkstyle version="6.5">
19:33:41   <file name="maintenance/deleteLocalPasswords.php">
19:33:41     <error line="61" severity="warning" message="Returning type \Wikimedia\Rdbms\DBConnRef but getUserDB() is declared to return \Wikimedia\Rdbms\IMaintainableDatabase" source="PhanTypeMismatchReturn"/>
19:33:41   </file>
19:33:41 </checkstyle>

See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/527158 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/485512 as an example.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Bust the database connection cache.	Dbarratt	mediawiki/extensions/CentralAuth	master	+4 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	TheDJ	T190350 Epic: ⚡️ Partial blocks
Open	None	T226651 Replace counts of blocked pages/namespaces for partial blocks with lists of them on Special:CentralAuth
Open	None	T229895 Refactor user management logic into a UserManager service
Open	None	T238235 Update API meta=globaluserinfo to include the same blocking info on the special page
Resolved	dbarratt	T200938 Special:CentralAuth should provide the same blocking information as Special:BlockList does
Resolved	dbarratt	T229613 CentralAuth tests are broken

Event Timeline

Urbanecm created this task.Aug 1 2019, 7:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2019, 7:39 PM

Breaks all work on extension => at least high, if not UBN.

This is just the phan breakage for dozens of repos, right?

In T229613#5385647, @Jdforrester-WMF wrote:

This is just the phan breakage for dozens of repos, right?

Not sure, Adding ci-test-error (WMF-deployed Build Failure) per ci-test-error description.

CentralAuth isn't in the gate so this isn't a shared build failure.

In T229613#5385676, @Jdforrester-WMF wrote:

CentralAuth isn't in the gate so this isn't a shared build failure.

Jdforrester-WMF merged a task: T229690: Returning type \Wikimedia\Rdbms\DBConnRef but getUserDB() is declared to return \Wikimedia\Rdbms\IMaintainableDatabase.Aug 2 2019, 7:54 PM

Jdforrester-WMF added a subscriber: dbarratt.

Change 527630 had a related patch set uploaded (by Jforrester; owner: Dbarratt):
[mediawiki/extensions/CentralAuth@master] Bust the database connection cache.

https://gerrit.wikimedia.org/r/527630

gerritbot added a project: Patch-For-Review.Aug 2 2019, 7:55 PM

Jdforrester-WMF assigned this task to dbarratt.Aug 2 2019, 7:55 PM

Jdforrester-WMF edited projects, added: Anti-Harassment-Team (The Letter Song); removed: Continuous-Integration-Config.

Jdforrester-WMF added a parent task: T200938: Special:CentralAuth should provide the same blocking information as Special:BlockList does.

dbarratt moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.Aug 2 2019, 8:00 PM

Change 527630 abandoned by Dbarratt:
Bust the database connection cache.

https://gerrit.wikimedia.org/r/527630

Maintenance_bot removed a project: Patch-For-Review.Aug 2 2019, 11:10 PM