Page MenuHomePhabricator

CentralAuth tests are broken
Closed, ResolvedPublic

Description

All tests on mediawiki/extensions/CentralAuth are failing.

19:33:41 <?xml version="1.0" encoding="ISO-8859-15"?>
19:33:41 <checkstyle version="6.5">
19:33:41   <file name="maintenance/deleteLocalPasswords.php">
19:33:41     <error line="61" severity="warning" message="Returning type \Wikimedia\Rdbms\DBConnRef but getUserDB() is declared to return \Wikimedia\Rdbms\IMaintainableDatabase" source="PhanTypeMismatchReturn"/>
19:33:41   </file>
19:33:41 </checkstyle>

See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/527158 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/485512 as an example.

Details

Related Gerrit Patches:
mediawiki/extensions/CentralAuth : masterBust the database connection cache.

Event Timeline

Urbanecm created this task.Aug 1 2019, 7:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2019, 7:39 PM
Urbanecm triaged this task as High priority.Aug 1 2019, 7:39 PM

Breaks all work on extension => at least high, if not UBN.

Jdforrester-WMF added a subscriber: Jdforrester-WMF.

This is just the phan breakage for dozens of repos, right?

This is just the phan breakage for dozens of repos, right?

Not sure, Adding Wikimedia-production-error (Shared Build Failure) per ci-test-error description.

CentralAuth isn't in the gate so this isn't a shared build failure.

CentralAuth isn't in the gate so this isn't a shared build failure.

Ok

Change 527630 had a related patch set uploaded (by Jforrester; owner: Dbarratt):
[mediawiki/extensions/CentralAuth@master] Bust the database connection cache.

https://gerrit.wikimedia.org/r/527630

Change 527630 abandoned by Dbarratt:
Bust the database connection cache.

https://gerrit.wikimedia.org/r/527630

Umherirrender closed this task as Resolved.Aug 4 2019, 6:53 PM
Umherirrender added a subscriber: Umherirrender.

Seems fixed by https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralAuth/+/527658/, because the last patch sets not failing