Page MenuHomePhabricator
Create Task
Maniphest T229690

Returning type \Wikimedia\Rdbms\DBConnRef but getUserDB() is declared to return \Wikimedia\Rdbms\IMaintainableDatabase
Closed, DuplicatePublic
Actions

Description

Problem
When making a change to MediaWiki-extensions-CentralAuth this error is thrown by the CI:

<file name="maintenance/deleteLocalPasswords.php">
    <error line="61" severity="warning" message="Returning type \Wikimedia\Rdbms\DBConnRef but getUserDB() is declared to return \Wikimedia\Rdbms\IMaintainableDatabase" source="PhanTypeMismatchReturn"/>
</file>

or more clearly:

Returning type \Wikimedia\Rdbms\DBConnRef but getUserDB() is declared to return \Wikimedia\Rdbms\IMaintainableDatabase

in the file: maintenance/deleteLocalPasswords.php

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Replace use of wfGetDB() with Maintenance::getDB()Dbarrattmediawiki/extensions/CentralAuthmaster+1 -1
Customize query in gerrit

Event Timeline

dbarratt created this task.Aug 2 2019, 7:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 2 2019, 7:27 PM
dbarratt moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.Aug 2 2019, 7:27 PM
gerritbot added a comment.Aug 2 2019, 7:29 PM

Change 527620 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/CentralAuth@master] Replace use of wfGetDB() with Maintenance::getDB()

https://gerrit.wikimedia.org/r/527620

gerritbot added a project: Patch-For-Review.Aug 2 2019, 7:29 PM
dbarratt moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.Aug 2 2019, 7:31 PM
dbarratt added a parent task: T200938: Special:CentralAuth should provide the same blocking information as Special:BlockList does.
gerritbot added a comment.Aug 2 2019, 7:46 PM

Change 527620 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Replace use of wfGetDB() with Maintenance::getDB()

https://gerrit.wikimedia.org/r/527620

gerritbot added a comment.Aug 2 2019, 7:49 PM

Change 527630 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/CentralAuth@master] Bust the database connection cache.

https://gerrit.wikimedia.org/r/527630

Jdforrester-WMF closed this task as a duplicate of T229613: CentralAuth tests are broken.Aug 2 2019, 7:54 PM
Jdforrester-WMF removed a parent task: T200938: Special:CentralAuth should provide the same blocking information as Special:BlockList does.
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.17; 2019-08-06).Aug 2 2019, 8:00 PM
• Niharika changed the task status from Duplicate to Resolved.Aug 5 2019, 9:25 PM
• Niharika moved this task from Code Review 🔍 to Done (2019-20: Q2) on the Anti-Harassment-Team (The Letter Song) board.
dbarratt closed this task as a duplicate of T229613: CentralAuth tests are broken.Aug 5 2019, 9:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits