Page MenuHomePhabricator

Warning: EchoModerationController::moderate: transaction round 'MWCallableUpdate::doUpdate' still running
Closed, ResolvedPublic

Description

The DeferredUpdates::addCallableUpdate callback uses clearReplicaSnapshots() but METHOD is that of the callback caller (ModerationController::moderate). This matches the update's getOrigin() method, which is probably what DeferredUpdates::attemptUpdate() should use.

Event Timeline

Change 527634 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] deferred: make DeferredUpdates::attemptUpdate() use callback owners for $fnameTrxOwner

https://gerrit.wikimedia.org/r/527634

Krinkle triaged this task as Medium priority.
Krinkle added a project: MediaWiki-General.
Krinkle moved this task from Inbox to Doing (old) on the Performance-Team board.
Krinkle added a project: Regression.

Change 527634 merged by jenkins-bot:
[mediawiki/core@master] deferred: make DeferredUpdates::attemptUpdate() use callback owners for $fnameTrxOwner

https://gerrit.wikimedia.org/r/527634