Warning: EchoModerationController::moderate: transaction round 'MWCallableUpdate::doUpdate' still running
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aaron
	Aug 2 2019, 7:53 PM

Description

The DeferredUpdates::addCallableUpdate callback uses clearReplicaSnapshots() but METHOD is that of the callback caller (ModerationController::moderate). This matches the update's getOrigin() method, which is probably what DeferredUpdates::attemptUpdate() should use.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	deferred: make DeferredUpdates::attemptUpdate() use callback owners for $fnameTrxOwner	mediawiki/core	master	+30 -2

Customize query in gerrit

Related Objects

Mentioned Here: T228911: DBTransactionError "transaction round 'LinksUpdate::doUpdate' still running" (via RunSingleJob.php)

Event Timeline

aaron created this task.Aug 2 2019, 7:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 2 2019, 7:53 PM

Change 527634 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] deferred: make DeferredUpdates::attemptUpdate() use callback owners for $fnameTrxOwner

https://gerrit.wikimedia.org/r/527634

gerritbot added a project: Patch-For-Review.Aug 2 2019, 8:10 PM

Krinkle assigned this task to aaron.Aug 6 2019, 5:55 PM

Krinkle triaged this task as Medium priority.

Krinkle added a project: MediaWiki-General.

Krinkle moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.

Krinkle added a project: Regression.

Marostegui subscribed.Aug 7 2019, 8:35 AM

aaron moved this task from Doing (old) to Blocked (old) on the Performance-Team board.Aug 12 2019, 7:47 PM

• mobrovac added a project: Platform Team Workboards (Clinic Duty Team).Aug 14 2019, 11:20 AM

• mobrovac moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.

• mobrovac moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (Clinic Duty Team) board.Aug 14 2019, 12:22 PM

Change 527634 merged by jenkins-bot:
[mediawiki/core@master] deferred: make DeferredUpdates::attemptUpdate() use callback owners for $fnameTrxOwner

https://gerrit.wikimedia.org/r/527634

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 21 2019, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 21 2019, 8:10 PM

aaron closed this task as Resolved.Aug 21 2019, 8:22 PM

Warning: EchoModerationController::moderate: transaction round 'MWCallableUpdate::doUpdate' still runningClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Warning: EchoModerationController::moderate: transaction round 'MWCallableUpdate::doUpdate' still running
Closed, ResolvedPublic
Actions