Page MenuHomePhabricator

Warning: EchoModerationController::moderate: transaction round 'MWCallableUpdate::doUpdate' still running
Closed, ResolvedPublic

Description

The DeferredUpdates::addCallableUpdate callback uses clearReplicaSnapshots() but METHOD is that of the callback caller (ModerationController::moderate). This matches the update's getOrigin() method, which is probably what DeferredUpdates::attemptUpdate() should use.

Event Timeline

aaron created this task.Fri, Aug 2, 7:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Aug 2, 7:53 PM

Change 527634 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] deferred: make DeferredUpdates::attemptUpdate() use callback owners for $fnameTrxOwner

https://gerrit.wikimedia.org/r/527634

Krinkle assigned this task to aaron.Tue, Aug 6, 5:55 PM
Krinkle triaged this task as Normal priority.
Krinkle added a project: MediaWiki-General.
Krinkle moved this task from Inbox to Doing on the Performance-Team board.
Krinkle added a project: Regression.

Change 527634 merged by jenkins-bot:
[mediawiki/core@master] deferred: make DeferredUpdates::attemptUpdate() use callback owners for $fnameTrxOwner

https://gerrit.wikimedia.org/r/527634

aaron closed this task as Resolved.Wed, Aug 21, 8:22 PM