Page MenuHomePhabricator

Include svgmin into the CI processes
Closed, DeclinedPublic

Description

The MultimediaViewer extension has svgmin configurated, but it seems it is not run as part of CI to be sure that the svg is always in a optimized version.

This can result in differences when grunt is running on the repo, see T229762

Event Timeline

hashar moved this task from Backlog to Repo setup on the Continuous-Integration-Config board.
hashar updated the task description. (Show Details)
Demian subscribed.

Last change to svgmin settings was on 2018-11-29: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MultimediaViewer/+/476440

  • If svgmin's optimization changes, there's not much to win. There are 8 files >2KiB, 13 files between 1-2KiB, 18 below 1KiB. Running svgmin with 6 months or a year delay after an optimization would not matter much.
  • If svgmin's configuration changes, svgmin is ran by the developer.
  • MMV is not under development, the SVGs are not expected to change.

Running svgmin on each CI build would just consume resources without benefit. For this reason I'm boldly declining this task. Should a fundamental change happen to the handling of SVGs, it can be reopened and completed.