Edit conflict when editing an existing section when another editor added a new section in the meantime (&section=new)
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Incnis_Mrsi
	Aug 5 2019, 1:57 PM

Description

Currently submitting an edit after an intervening new section (&section=new) in many cases results in edit conflict. Even for a section edit where two chunks have zero overlap. IMHO when the current edit form is section=something, then it is safe enough to proceed with the edit without conflicting with the new section. The only necessary precaution results from the possibility that the thing added with section=new does not necessarily begin from a valid =…= heading.

Opinions?

If anybody is interested, Ī̲ can formulate a more stringent criterion for saving the section=something edit, which avoids some of remaining loopholes for unintended effects.

Related Objects

Mentioned Here: T59264: self-conflict when editing huge pages
T43338: Reduce edit conflicts by either telling users to edit a section only, or to have better logic to treat paragraphs, categories, templates independently
T49438: Creating new section may overwrite edit to another section
T55446: Edit conflicts for editing different sections on popular article

Event Timeline

Incnis_Mrsi created this task.Aug 5 2019, 1:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 5 2019, 1:57 PM

This sounds like a duplicate of T43338? Which code areas did you investigate?
Also see https://phabricator.wikimedia.org/T49438 or https://phabricator.wikimedia.org/T55446.

Kizule moved this task from Backlog to Edit conflict on the MediaWiki-Page-editing board.Aug 31 2019, 10:42 AM

@Incnis_Mrsi: Could you please answer the last comment? Thanks!

In T229823#5393033, @Aklapper wrote:

This sounds like a duplicate of T43338?

“paragraphs, categories, templates…” – no way, Ī̲ don’t propose to fit MediaWiki with AI. Only several checks based on a dumb (sub)section tree-like model of the page.

Which code areas did you investigate?

MediaWiki code? Did not look there at all.

Also see https://phabricator.wikimedia.org/T49438

Marginally tangential. As stated, “my” problem is about an extant-section edit submitted after an intervening section=new. Not about a new-section edit which corrupts data on its immediate saving – that might be a bug, but don’t blame me for it.

or https://phabricator.wikimedia.org/T55446.

Low specificity. Again, “my” problem is about intervening section=new edits, not edit conflicts in general.

Aklapper closed this task as a duplicate of T59264: self-conflict when editing huge pages.Oct 12 2019, 2:58 PM

And this, of course, is not a duplicate of T59264.

"And this, of course, is a duplicate of T59264."

And "of course" that previous sentence that I just wrote is not too helpful, as it offers zero argumentation.
An argumentation should pick up some existing sentences and refer to them. I have no idea why stuff like "AI" was even mentioned in a previous comment.
It's also not too helpful to argue about code logic when not having looked at any code at all.

I second this bug report. This bug happens to me quite often when I reply to an existing section (&section=x) on talk pages and some other editor added a new section in the meantime (&section=new). Both sections are on the same heading level, but obviously different.

The expected behaviour is that no edit conflict is detected, since both edits happen in different sections
The actual behavious is that an edit conflict is detected with the new section as the cause

Pruem reopened this task as Open.Aug 28 2021, 2:46 PM

Aklapper renamed this task from Edit conflict with section=new to Edit conflict when editing an existing section when another editor added a new section in the meantime (&section=new).Aug 29 2021, 11:22 AM

It could be that this only happens if one attempts to edit the last current section of a talk/meta page. I can't actually recall this happening in other cases.

Edit conflict when editing an existing section when another editor added a new section in the meantime (&section=new)Open, Needs TriagePublicActions

Description

Related Objects

Event Timeline

Edit conflict when editing an existing section when another editor added a new section in the meantime (&section=new)
Open, Needs TriagePublic
Actions