Page MenuHomePhabricator

In Space blog the "No comments" link doesn't work
Open, LowPublic

Description

E.g. at
https://space.wmflabs.org/2019/08/05/tech-news-2019-week-32/
the text "No Comments" at top is linking to
https://space.wmflabs.org/2019/08/05/tech-news-2019-week-32/#respond
but there's no existing #respond anchor in the HTML, so the page doesn't scroll when we click it.

It does work as expected if there are 1 or more comments, but it uses a different anchor-target (#comments), which might be the problem above. I.e.
https://space.wmflabs.org/2019/07/25/structured-data-on-commons-a-blog-series/
the text "1 Comment" at top is linking to
https://space.wmflabs.org/2019/07/25/structured-data-on-commons-a-blog-series/#comments

Ah, yes, if I hack the URL to use that #comments anchor, then the link works. E.g.
https://space.wmflabs.org/2019/08/05/tech-news-2019-week-32/#comments

Event Timeline

Quiddity created this task.Aug 5 2019, 4:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 5 2019, 4:30 PM
Qgil triaged this task as Low priority.Aug 22 2019, 2:15 PM
Qgil added subscribers: hdothiduc, Qgil.

@hdothiduc Did you work on this theme changes? Does this ring a bell?

I actually think this might be my doing. I moved some elements around so that the end of an article (where the author box, metadata, and comments appear) works differently. This may have broken the Comments anchor from Discourse. I'll investigate.

Qgil assigned this task to CKoerner_WMF.Aug 26 2019, 6:16 AM
Qgil edited projects, added Space (Jul-Sep-2019); removed Space.
CKoerner_WMF moved this task from Jul-Sep-2019 to Inbox on the Space board.Sep 26 2019, 8:50 PM
CKoerner_WMF edited projects, added Space; removed Space (Jul-Sep-2019).
Aklapper removed a subscriber: Aklapper.Thu, Oct 31, 10:16 AM