Page MenuHomePhabricator

Fix quibble to silence INFO log output from the backend server in karma runs unless a test fails
Open, Needs TriagePublic0 Estimated Story Points

Description

Right now selenium test output is very messy and almost entirely pointless. Let's shrink the noise so people focus on the results.

Event Timeline

https://github.com/wikimedia/quibble/blob/master/quibble/backend.py#288 ->

stream_relay(self.server, self.server.stderr, self.log.info)

Maybe move this to self.log.debug?

hashar added a subscriber: hashar.Aug 19 2019, 2:23 PM

I have indeed made Quibble to relay the PHP embedded web server to info. just elevate it to debug and we should be fine +1!

We will probably later need a way to finely tune the logging config from the CLI or via a config file.

The reason I have made it to relay everything at info level is that the PHP built-in server writes access log as well as potential errors solely on stderr without any way to set a minimal log level. If we relay to debug we would miss the webserver errors, then they are probably available via the mw-debug-www.log error log.

I thought about parsing the emitted messages to filter out access log, but that sounds too fragile. Maybe we can just spawn the builtin server with error_log set.

hashar moved this task from Backlog to Enhancement on the Quibble board.Oct 8 2019, 7:24 PM