`action=query&meta=messagegroupstats` api fails, saying "mgsgroup" must be set when it is
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DannyS712
	Aug 6 2019, 9:52 PM

Description

Steps to reproduce:

Go to https://meta.wikimedia.org/w/api.php?action=query&meta=messagegroupstats&mgsgroup=page-Example (this is the example api query given at https://meta.wikimedia.org/w/api.php?action=help&modules=query%2Bmessagegroupstats)

Actual result:

{
    "error": {
        "code": "nomgsgroup",
        "info": "The \"mgsgroup\" parameter must be set.",
        "*": "See https://meta.wikimedia.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at &lt;https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce&gt; for notice of API deprecations and breaking changes."
    },
    "servedby": "mw1231"
}

Expected result

The mgsgroup parameter passed in the query is understood

I'll note that the source specifies that apierror-missingparam is thrown when MessageGroups::getGroup( $params['group'] ) evaluates to false - maybe a different error should be returned

Details

	Subject	Repo	Branch	Lines +/-
	Fix api error messages when bad parameters are passed.	mediawiki/extensions/Translate	master	+4 -6

Customize query in gerrit

Event Timeline

DannyS712 created this task.Aug 6 2019, 9:52 PM

Restricted Application added a project: User-DannyS712. · View Herald TranscriptAug 6 2019, 9:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The same issue arises at https://meta.wikimedia.org/w/api.php?action=query&list=messagecollection&mcgroup=page-Example

I suggest that apierror-badparameter be thrown instead, since the issue isn't that the parameter wasn't set, but that it wasn't valid. This would be for all translate APIs where this is an issue. Since the parameters are listed as required, that restriction is still enforced by the Api base

This looks like to be the case of using confusing error code, but no issue in functionality.

DannyS712 claimed this task.Aug 17 2019, 9:47 AM

Change 530715 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Fix api error messages when bad parameters are passed.

https://gerrit.wikimedia.org/r/530715

gerritbot added a project: Patch-For-Review.Aug 18 2019, 2:21 AM

DannyS712 moved this task from Next to Awaiting review and deployment on the User-DannyS712 board.Aug 18 2019, 3:36 AM

Change 530715 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix api error messages when bad parameters are passed.

https://gerrit.wikimedia.org/r/530715

Maintenance_bot removed a project: Patch-For-Review.Aug 18 2019, 8:10 AM

DannyS712 closed this task as Resolved.Aug 18 2019, 9:26 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 20 2019, 10:01 PM

DannyS712 moved this task from Awaiting review and deployment to Merged on the User-DannyS712 board.Aug 21 2019, 9:34 PM

Mentioned in SAL (#wikimedia-releng) [2019-12-29T20:18:41Z] <hauskatze> github: Mirror deleted: "wikimedia/analytics-limn-flow-data" (T229981)

In T229981#5765961, @Stashbot wrote:

Mentioned in SAL (#wikimedia-releng) [2019-12-29T20:18:41Z] <hauskatze> github: Mirror deleted: "wikimedia/analytics-limn-flow-data" (T229981)

Please disregard. I entered the wrong ticket number while logging.

`action=query&meta=messagegroupstats` api fails, saying "mgsgroup" must be set when it isClosed, ResolvedPublicActions

Description

Details

Event Timeline

`action=query&meta=messagegroupstats` api fails, saying "mgsgroup" must be set when it is
Closed, ResolvedPublic
Actions