[BUG] Handle footer menu icon style correctly
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	cooltey
	Aug 6 2019, 11:33 PM

Description

This is an issue about mobile-html

Steps to reproduce

Open any article in either Traditional Chinese or Simplified Chinese
Scroll down to the bottom to see the "About this article" section

Expected

Screenshot_1565133966.png (2×1 px, 249 KB)

Actual

Screenshot_1565133929.png (2×1 px, 391 KB)

I found that the <body> tag in Chinese articles do not include dir="ltr", which does not match any style settings in the page-library

Please see: https://github.com/wikimedia/wikimedia-page-library/blob/master/src/transform/FooterMenu.css#L22-L25

This can be solved either in wikimedia-page-library or Page Content Service.
cc @JoeWalsh @bearND @MSantos

Details

	Subject	Repo	Branch	Lines +/-
	mobile-html: fix footer menu icon style	mediawiki/services/mobileapps	master	+6 -2

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		None	T169242 Develop Page Content Service for Reading Clients
Resolved		None	T177425 Develop General Layer of PCS
Resolved		None	T177433 Develop HTML Content API to be used with companion structured JSON APIs
Resolved	Spike	• JMinor	T228459 mobile-html: prioritized list of remaining bugs & feature requests
Resolved	BUG REPORT	MSantos	T229984 [BUG] Handle footer menu icon style correctly

Event Timeline

cooltey created this task.Aug 6 2019, 11:33 PM

Restricted Application added a project: Product-Infrastructure-Team-Backlog-Deprecated. · View Herald TranscriptAug 6 2019, 11:33 PM

Restricted Application changed the subtype of this task from "Task" to "Bug Report". · View Herald Transcript

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

cooltey updated the task description. (Show Details)Aug 6 2019, 11:57 PM

Shizhao added a project: Chinese-Sites.Aug 7 2019, 2:35 AM

LGoto triaged this task as Medium priority.Aug 7 2019, 3:37 PM

LGoto moved this task from Needs triage to Upcoming on the Product-Infrastructure-Team-Backlog-Deprecated board.

• Jhernandez added a parent task: T228459: mobile-html: prioritized list of remaining bugs & feature requests.Aug 7 2019, 3:39 PM

SunAfterRain subscribed.Aug 9 2019, 8:44 AM

MSantos edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.Aug 12 2019, 6:08 PM

Change 529822 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/services/mobileapps@master] mobile-html: fix footer menu icon style

https://gerrit.wikimedia.org/r/529822

gerritbot added a project: Patch-For-Review.Aug 12 2019, 7:37 PM

MSantos claimed this task.Aug 12 2019, 7:37 PM

MSantos moved this task from To Do to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.

Change 529822 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] mobile-html: fix footer menu icon style

https://gerrit.wikimedia.org/r/529822

MSantos moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Aug 13 2019, 2:56 PM

Mentioned in SAL (#wikimedia-operations) [2019-08-15T17:41:28Z] <mbsantos@deploy1001> Started deploy [mobileapps/deploy@1bd2bea]: Update service-mobileapp-node to 5c1da03 (T230067 T229984)

Mentioned in SAL (#wikimedia-operations) [2019-08-15T17:47:21Z] <mbsantos@deploy1001> Finished deploy [mobileapps/deploy@1bd2bea]: Update service-mobileapp-node to 5c1da03 (T230067 T229984) (duration: 05m 53s)

MSantos moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Aug 19 2019, 10:55 PM

MSantos closed this task as Resolved.Sep 18 2019, 4:13 PM

MSantos removed a project: Patch-For-Review.

Shizhao moved this task from Backlog to Closed on the Chinese-Sites board.Sep 19 2019, 8:27 AM

[BUG] Handle footer menu icon style correctlyClosed, ResolvedPublicBUG REPORTActions