Test on concrete values with selenium
Closed, ResolvedPublic
Actions

Description

Thanks to https://gerrit.wikimedia.org/r/#/c/528125/ there is now the possibility to test on concrete values for the selenium test sets.
We should use this opportunity and just do that.

Details

	Subject	Repo	Branch	Lines +/-
	bridge: assert correct value in browser tests	mediawiki/extensions/Wikibase	master	+33 -14

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Lydia_Pintscher	T224833 first client edit for simple typo
Resolved	Lydia_Pintscher	T226998 Add editing widget/input to client edit modal
Resolved	Lucas_Werkmeister_WMDE	T230008 Test on concrete values with selenium

Event Timeline

• Matthias_Geisler_WMDE created this task.Aug 7 2019, 10:43 AM

I assume this refers to the final TODO in init.js / “shows the current targetValue”, where we currently don’t check that the value is what we expect?

Lucas_Werkmeister_WMDE claimed this task.Aug 7 2019, 5:33 PM

Lucas_Werkmeister_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-3 board.

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-3 board.Aug 7 2019, 5:43 PM

Change 528901 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: assert correct value in browser tests

https://gerrit.wikimedia.org/r/528901

gerritbot added a project: Patch-For-Review.Aug 7 2019, 5:43 PM

• Pablo-WMDE closed this task as Resolved.Aug 9 2019, 1:39 PM

• Pablo-WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-3 board.

Change 528901 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: assert correct value in browser tests

https://gerrit.wikimedia.org/r/528901

Maintenance_bot removed a project: Patch-For-Review.Aug 9 2019, 3:10 PM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 20 2019, 4:01 PM