Thanks to https://gerrit.wikimedia.org/r/#/c/528125/ there is now the possibility to test on concrete values for the selenium test sets.
We should use this opportunity and just do that.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| bridge: assert correct value in browser tests | mediawiki/extensions/Wikibase | master | +33 -14 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Lydia_Pintscher | T224833 first client edit for simple typo | |||
| Resolved | Lydia_Pintscher | T226998 Add editing widget/input to client edit modal | |||
| Resolved | Lucas_Werkmeister_WMDE | T230008 Test on concrete values with selenium |
Event Timeline
Comment Actions
I assume this refers to the final TODO in init.js / “shows the current targetValue”, where we currently don’t check that the value is what we expect?
Comment Actions
Change 528901 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: assert correct value in browser tests
Comment Actions
Change 528901 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: assert correct value in browser tests