Page MenuHomePhabricator

Remove defined( 'MEDIAWIKI' ) entry point check for files containing only classes
Closed, ResolvedPublic

Description

I am doing some mass uploads to remove the unnecessary checks:

if ( !defined( 'MEDIAWIKI' ) ) {
    die( 'Not a valid entry point.' );
}

See https://www.mediawiki.org/w/index.php?title=Register_globals&oldid=3063934#Make_sure_code_is_only_executed_in_the_right_context for more information

See https://gerrit.wikimedia.org/r/#/q/topic:definedMediaWiki+(status:open+OR+status:merged) for all changes

Details

Related Gerrit Patches:
mediawiki/extensions/OpenID : masterRemove entry point check for files that only contain classes
mediawiki/extensions/RelatedLinks : masterRemove entry point check for files only contain classes
mediawiki/extensions/UploadLogo : masterRemove entry point check for files only contain classes
mediawiki/extensions/SemanticTasks : masterRemove entry point check for files only contain classes
mediawiki/extensions/TimezoneSelector : masterRemove entry point check for files only contain classes
mediawiki/extensions/SelectCategory : masterRemove entry point check for files only contain classes
mediawiki/extensions/MagicNumberedHeadings : masterRemove entry point check for files only contain classes
mediawiki/extensions/TweetANew : masterRemove entry point check for files only contain classes
mediawiki/extensions/SpamBlacklist : masterRemove entry point check for files only contain classes
mediawiki/skins/Daddio : masterRemove entry point check for files only contain classes
mediawiki/extensions/LinkedWiki : masterRemove entry point check for files only contain classes
mediawiki/extensions/MassEditRegex : masterRemove entry point check for files only contain classes
mediawiki/skins/mediawiki-strapping : masterRemove entry point check for files only contain classes
mediawiki/extensions/AddPersonalUrls : masterRemove entry point check for files only contain classes
mediawiki/extensions/BreadCrumbs : masterRemove entry point check for files only contain classes
mediawiki/extensions/MathSearch : masterRemove entry point check for files only contain classes
mediawiki/extensions/LandingCheck : masterRemove entry point check for files only contain classes
mediawiki/extensions/Carp : masterRemove entry point check for files only contain classes
mediawiki/extensions/News : masterRemove entry point check for files only contain classes
mediawiki/extensions/RevisionCommentSupplement : masterRemove entry point check for files only contain classes
mediawiki/extensions/NumerAlpha : masterRemove entry point check for files only contain classes
mediawiki/extensions/CategorySortHeaders : masterRemove entry point check for files only contain classes
mediawiki/extensions/DynamicPageListEngine : masterRemove entry point check for files only contain classes
mediawiki/extensions/DataTable2 : masterRemove entry point check for files only contain classes
mediawiki/extensions/BlockAndNuke : masterRemove entry point check for files only contain classes
mediawiki/extensions/GoToShell : masterRemove entry point check for files only contain classes
mediawiki/extensions/GoogleNewsSitemap : masterRemove entry point check for files only contain classes
mediawiki/extensions/CloseWikis : masterRemove entry point check for files only contain classes
mediawiki/extensions/ReplaceSet : masterRemove entry point check for files only contain classes
mediawiki/extensions/SacredText : masterRemove entry point check for files only contain classes
mediawiki/extensions/ShowRealUsernames : masterRemove entry point check for files only contain classes
mediawiki/extensions/TemplateInfo : masterRemove entry point check for files only contain classes
mediawiki/extensions/ShortUrl : masterRemove entry point check for files only contain classes
mediawiki/extensions/Sudo : masterRemove entry point check for files only contain classes
mediawiki/extensions/UnicodeConverter : masterRemove entry point check for files only contain classes
mediawiki/extensions/WantedPagesFromNS : masterRemove entry point check for files only contain classes
mediawiki/extensions/Memento : masterRemove entry point check for files only contain classes
mediawiki/extensions/AddThis : masterRemove entry point check for files only contain classes
mediawiki/extensions/DebugTemplates : masterRemove entry point check for files only contain classes
mediawiki/extensions/DumpHTML : masterRemove entry point check for files only contain classes
mediawiki/extensions/NetworkAuth : masterRemove entry point check for files only contain classes
mediawiki/extensions/Commentbox : masterRemove entry point check for files only contain classes
mediawiki/extensions/Special404 : masterRemove entry point check for files only contain classes
mediawiki/extensions/Challenge : masterRemove entry point check for files only contain classes
mediawiki/skins/Nimbus : masterRemove entry point check for files only contain classes
mediawiki/skins/Tempo : masterRemove entry point check for files only contain classes
mediawiki/extensions/DPLforum : masterRemove entry point check for files only contain classes
mediawiki/extensions/Maintenance : masterRemove entry point check for files only contain classes
mediawiki/extensions/PollNY : masterRemove entry point check for files only contain classes
mediawiki/extensions/SpamRegex : masterRemove entry point check for files only contain classes

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 528836 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/LandingCheck@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528836

Change 528837 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/LinkedWiki@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528837

Change 528838 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/MagicNumberedHeadings@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528838

Change 528839 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Maintenance@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528839

Change 528840 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/MassEditRegex@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528840

Change 528841 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/MathSearch@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528841

Change 528842 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Memento@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528842

Change 528843 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/NetworkAuth@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528843

Change 528844 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/News@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528844

Change 528845 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/NumerAlpha@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528845

Change 528852 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/OpenID@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528852

Change 528853 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/PollNY@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528853

Change 528854 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/RelatedLinks@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528854

Change 528855 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/ReplaceSet@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528855

Change 528858 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/RevisionCommentSupplement@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528858

Change 528859 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/SacredText@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528859

Change 528860 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/SelectCategory@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528860

Change 528861 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/SemanticTasks@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528861

Change 528862 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/ShortUrl@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528862

Change 528863 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/ShowRealUsernames@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528863

Change 528864 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/SpamBlacklist@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528864

Change 528865 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/SpamRegex@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528865

Change 528866 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Special404@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528866

Change 528867 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Sudo@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528867

Change 528868 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/TemplateInfo@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528868

Change 528869 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/TimezoneSelector@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528869

Change 528870 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/TweetANew@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528870

Change 528872 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/UnicodeConverter@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528872

Change 528873 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/UploadLogo@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528873

Change 528874 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/WantedPagesFromNS@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528874

The rest of this code snippet is part of php entry points and gets removed after the migration to extension.json and the remove of the entry point (T140850)

Change 528865 merged by jenkins-bot:
[mediawiki/extensions/SpamRegex@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528865

Change 528853 merged by jenkins-bot:
[mediawiki/extensions/PollNY@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528853

Change 528839 merged by jenkins-bot:
[mediawiki/extensions/Maintenance@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528839

Change 528819 merged by jenkins-bot:
[mediawiki/extensions/DPLforum@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528819

Change 528799 merged by jenkins-bot:
[mediawiki/skins/Tempo@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528799

Change 528797 merged by jenkins-bot:
[mediawiki/skins/Nimbus@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528797

Change 528814 merged by jenkins-bot:
[mediawiki/extensions/Challenge@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528814

Change 528866 merged by jenkins-bot:
[mediawiki/extensions/Special404@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528866

Change 528816 merged by jenkins-bot:
[mediawiki/extensions/Commentbox@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528816

Change 528843 merged by jenkins-bot:
[mediawiki/extensions/NetworkAuth@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528843

Change 528820 merged by jenkins-bot:
[mediawiki/extensions/DumpHTML@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528820

Change 528818 merged by jenkins-bot:
[mediawiki/extensions/DebugTemplates@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528818

Change 528809 merged by jenkins-bot:
[mediawiki/extensions/AddThis@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528809

Change 528842 merged by Umherirrender:
[mediawiki/extensions/Memento@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528842

Change 528874 merged by jenkins-bot:
[mediawiki/extensions/WantedPagesFromNS@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528874

Change 528864 merged by jenkins-bot:
[mediawiki/extensions/SpamBlacklist@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528864

Change 528872 merged by jenkins-bot:
[mediawiki/extensions/UnicodeConverter@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528872

Change 528867 merged by jenkins-bot:
[mediawiki/extensions/Sudo@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528867

Change 528862 merged by jenkins-bot:
[mediawiki/extensions/ShortUrl@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528862

Change 528868 merged by jenkins-bot:
[mediawiki/extensions/TemplateInfo@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528868

Change 528863 merged by jenkins-bot:
[mediawiki/extensions/ShowRealUsernames@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528863

Change 528859 merged by jenkins-bot:
[mediawiki/extensions/SacredText@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528859

Change 528855 merged by jenkins-bot:
[mediawiki/extensions/ReplaceSet@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528855

Change 528815 merged by jenkins-bot:
[mediawiki/extensions/CloseWikis@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528815

Change 528832 merged by jenkins-bot:
[mediawiki/extensions/GoogleNewsSitemap@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528832

Change 528834 merged by jenkins-bot:
[mediawiki/extensions/GoToShell@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528834

Change 528810 merged by jenkins-bot:
[mediawiki/extensions/BlockAndNuke@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528810

Change 528817 merged by jenkins-bot:
[mediawiki/extensions/DataTable2@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528817

Change 528821 merged by jenkins-bot:
[mediawiki/extensions/DynamicPageListEngine@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528821

Change 528813 merged by jenkins-bot:
[mediawiki/extensions/CategorySortHeaders@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528813

Change 528845 merged by jenkins-bot:
[mediawiki/extensions/NumerAlpha@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528845

Change 528858 merged by jenkins-bot:
[mediawiki/extensions/RevisionCommentSupplement@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528858

Change 528844 merged by jenkins-bot:
[mediawiki/extensions/News@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528844

Change 528812 merged by jenkins-bot:
[mediawiki/extensions/Carp@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528812

Change 528836 merged by jenkins-bot:
[mediawiki/extensions/LandingCheck@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528836

Change 528841 merged by jenkins-bot:
[mediawiki/extensions/MathSearch@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528841

Change 528811 merged by jenkins-bot:
[mediawiki/extensions/BreadCrumbs@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528811

Change 528802 merged by jenkins-bot:
[mediawiki/extensions/AddPersonalUrls@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528802

Change 528798 merged by jenkins-bot:
[mediawiki/skins/mediawiki-strapping@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528798

Change 528840 merged by jenkins-bot:
[mediawiki/extensions/MassEditRegex@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528840

Change 528837 merged by jenkins-bot:
[mediawiki/extensions/LinkedWiki@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528837

Change 528796 merged by jenkins-bot:
[mediawiki/skins/Daddio@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528796

Change 528870 merged by jenkins-bot:
[mediawiki/extensions/TweetANew@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528870

Change 528838 merged by Umherirrender:
[mediawiki/extensions/MagicNumberedHeadings@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528838

Change 528860 merged by Umherirrender:
[mediawiki/extensions/SelectCategory@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528860

Change 528869 merged by Umherirrender:
[mediawiki/extensions/TimezoneSelector@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528869

Change 528861 merged by Umherirrender:
[mediawiki/extensions/SemanticTasks@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528861

Change 528873 merged by Umherirrender:
[mediawiki/extensions/UploadLogo@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528873

Change 528854 merged by Umherirrender:
[mediawiki/extensions/RelatedLinks@master] Remove entry point check for files only contain classes

https://gerrit.wikimedia.org/r/528854

Change 528852 merged by jenkins-bot:
[mediawiki/extensions/OpenID@master] Remove entry point check for files that only contain classes

https://gerrit.wikimedia.org/r/528852

Umherirrender closed this task as Resolved.Oct 4 2019, 1:42 PM
Umherirrender triaged this task as Medium priority.
DannyS712 added a subscriber: DannyS712.

[batch] remove patch for review tag from resolved tasks