Page MenuHomePhabricator

Create a "References" page for mobile-html
Closed, ResolvedPublic

Description

The visual below is based on @Dbrant’s current prototype.


Background: T218144

Example response: https://en.wikipedia.org/api/rest_v1/page/references/Dog

Event Timeline

@Dbrant - It would be preferable to talk about tickets and give them a priority before putting them into a work in progress column. Is this something you've spoken to @schoenbaechler about?

Charlotte raised the priority of this task from Medium to High.Jan 7 2020, 5:04 PM

Thanks for working on this @Dbrant. A few comments below:

01) Use Roboto Regular not Roboto Italic for all text

Screenshot_20200122-130743.png (2×1 px, 241 KB)

02) Align all arrow-up icons to the right

Screenshot_20200122-131806.png (2×1 px, 277 KB)

03) General question, can you confirm that this is Roboto 14sp ? It seems small.

Screenshot_20200122-132007.png (2×1 px, 314 KB)

04) Tap height of this element should at least be 48dp (related task: T226094)

Screenshot_20200122-132154.png (2×1 px, 303 KB)

In T230047#5822758, @schoenbaechler wrote:

01) Use Roboto Regular not Roboto Italic for all text

Done!

02) Align all arrow-up icons to the right

Done!

03) General question, can you confirm that this is Roboto 14sp ? It seems small.

Yes!

04) Tap height of this element should at least be 48dp (related task: T226094)

This is a wikimedia-page-library issue, and will need to be fixed in the mobile-html response.

Thanks @Dbrant. The issues mentioned in T230047#5822758 are fixed, but tapping an element currently does not scroll to the corresponding element (tested in 2.7.50309-alpha-2020-02-06). It closes the references bottom sheet and stays at the same position. Plus: can we make the whole list item a tap target to make tapping an item more accessible? Of course, the links in an item should still be tappable too.

Screenshot_20200210-155045.png (2×1 px, 265 KB)

tapping an element currently does not scroll to the corresponding element

Done

can we make the whole list item a tap target to make tapping an item more accessible?

I'm afraid it's not possible to make the whole item clickable, while also making the links within the text clickable.

@Dbrant

can we make the whole list item a tap target to make tapping an item more accessible?

I'm afraid it's not possible to make the whole item clickable, while also making the links within the text clickable.

Then we need to increase the tap target size of the arrow on the right to at least 48dp. It’s currently hard to tap and interferes with the scrollbar. Can you optimize that aspect? Thx.