Page MenuHomePhabricator

Delayed jobs fail validation in eventgate
Closed, ResolvedPublic

Description

Jobs that are delayed contain a delay_until field that in new schemas is required to have a date-time format, however it's emitted in internal Mediawiki date format and fails validation. I think it's a good idea to make a schema validate the date-time format, so the following needs to be done:

For transition we need:

  • Verify old schema will accept date-time
  • Make change-prop support both formats
  • Switch MediaWiki to emitting proper date-time format
  • After switch to eventgate, remove fallback to old format from ChangeProp

Event Timeline

Pchelolo created this task.Aug 7 2019, 5:54 PM

Change 528914 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/EventBus@master] User ISO8601 format for job release timestamp.

https://gerrit.wikimedia.org/r/528914

Mentioned in SAL (#wikimedia-operations) [2019-08-07T21:49:06Z] <ppchelko@deploy1001> Started deploy [cpjobqueue/deploy@a151f4e]: Prepare for eventgate transition T230049 T230048

Mentioned in SAL (#wikimedia-operations) [2019-08-07T21:50:05Z] <ppchelko@deploy1001> Finished deploy [cpjobqueue/deploy@a151f4e]: Prepare for eventgate transition T230049 T230048 (duration: 00m 59s)

Pchelolo updated the task description. (Show Details)Aug 7 2019, 9:51 PM

Change 528914 merged by jenkins-bot:
[mediawiki/extensions/EventBus@master] User ISO8601 format for job release timestamp.

https://gerrit.wikimedia.org/r/528914

elukey edited projects, added Analytics; removed Analytics-Kanban.Aug 14 2019, 10:17 AM
elukey moved this task from Incoming to Radar on the Analytics board.Aug 19 2019, 3:34 PM

Mentioned in SAL (#wikimedia-operations) [2019-09-11T20:06:21Z] <ppchelko@deploy1001> Started deploy [cpjobqueue/deploy@2c9e409]: Clean up old event style support T230049

Mentioned in SAL (#wikimedia-operations) [2019-09-11T20:07:14Z] <ppchelko@deploy1001> Finished deploy [cpjobqueue/deploy@2c9e409]: Clean up old event style support T230049 (duration: 00m 53s)