Page MenuHomePhabricator

Remove globalblocks tables from wikis
Closed, ResolvedPublic

Description

Some wikis will have globalblocks table in the database, which is empty and unused

Highlighted by https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GlobalBlocking/+/471031/ and https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikimediaMaintenance/+/471499/

The table can be removed from all wiki databases (but obviously not centralauth.globalblocks)

The table, apart from centralauth exists on:

  • s3
    1advisorswiki
    2adywiki
    3amwikimedia
    4arbcom_cswiki
    5aswikisource
    6atjwiki
    7azbwiki
    8bnwikivoyage
    9cawikimedia
    10cnwikimedia
    11dewikivoyage
    12dinwiki
    13dtywiki
    14ecwikimedia
    15electcomwiki
    16elwikivoyage
    17eswikivoyage
    18euwikisource
    19fawikivoyage
    20fdcwiki
    21fiwikivoyage
    22fixcopyrightwiki
    23frwikivoyage
    24gomwiki
    25gorwiki
    26hewikivoyage
    27hifwiktionary
    28hiwikimedia
    29hiwikiversity
    30hiwikivoyage
    31hywwiki
    32id_internalwikimedia
    33idwikimedia
    34iegcomwiki
    35inhwiki
    36itwikivoyage
    37jamwiki
    38kbpwiki
    39kowikiversity
    40legalteamwiki
    41lfnwiki
    42liwikinews
    43loginwiki
    44lrcwiki
    45maiwiki
    46maiwikimedia
    47minwiki
    48nlwikivoyage
    49olowiki
    50ombudsmenwiki
    51orwikisource
    52pawikisource
    53plwikivoyage
    54pmswikisource
    55projectcomwiki
    56pswikivoyage
    57ptwikimedia
    58ptwikivoyage
    59punjabiwikimedia
    60romdwikimedia
    61rowikivoyage
    62ruwikivoyage
    63sahwikiquote
    64satwiki
    65sawikiquote
    66shnwiki
    67svwikivoyage
    68tcywiki
    69techconductwiki
    70testwikidatawiki
    71transitionteamwiki
    72tyvwiki
    73ukwikivoyage
    74vecwiktionary
    75viwikivoyage
    76votewiki
    77wbwikimedia
    78wikimania2013wiki
    79wikimania2014wiki
    80wikimania2015wiki
    81wikimania2016wiki
    82wikimania2017wiki
    83wikimania2018wiki
    84wikimaniawiki
    85yuewiktionary
    86zerowiki
    87zhwikiversity
    88zhwikivoyage
  • s4 testcommonswiki
  • s5 enwikivoyage
  • s8 wikidatawiki

Event Timeline

Reedy added a project: DBA.
Reedy updated the task description. (Show Details)
Marostegui triaged this task as Medium priority.Aug 8 2019, 5:59 AM
Marostegui moved this task from Triage to Pending comment on the DBA board.

I have confirmed that all the tables are empty on all those s3 wikis:

# for i in `mysql.py -hdb1075 information_schema -e "select table_schema from tables where table_name='globalblocks'" -BN`; do echo $i; mysql.py -hdb1075 $i -e "select count(*) from globalblocks"; done
advisorswiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
adywiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
amwikimedia
+----------+
| count(*) |
+----------+
|        0 |
+----------+
arbcom_cswiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
aswikisource
+----------+
| count(*) |
+----------+
|        0 |
+----------+
atjwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
azbwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
bnwikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+
cawikimedia
+----------+
| count(*) |
+----------+
|        0 |
+----------+
cnwikimedia
+----------+
| count(*) |
+----------+
|        0 |
+----------+
dewikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+
dinwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
dtywiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
ecwikimedia
+----------+
| count(*) |
+----------+
|        0 |
+----------+
electcomwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
elwikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+
eswikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+
euwikisource
+----------+
| count(*) |
+----------+
|        0 |
+----------+
fawikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+
fdcwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
fiwikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+
fixcopyrightwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
frwikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+
gomwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
gorwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
hewikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+
hifwiktionary
+----------+
| count(*) |
+----------+
|        0 |
+----------+
hiwikimedia
+----------+
| count(*) |
+----------+
|        0 |
+----------+
hiwikiversity
+----------+
| count(*) |
+----------+
|        0 |
+----------+
hiwikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+
hywwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
id_internalwikimedia
+----------+
| count(*) |
+----------+
|        0 |
+----------+
idwikimedia
+----------+
| count(*) |
+----------+
|        0 |
+----------+
iegcomwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
inhwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
itwikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+
jamwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
kbpwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
kowikiversity
+----------+
| count(*) |
+----------+
|        0 |
+----------+
legalteamwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
lfnwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
liwikinews
+----------+
| count(*) |
+----------+
|        0 |
+----------+
loginwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
lrcwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
maiwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
maiwikimedia
+----------+
| count(*) |
+----------+
|        0 |
+----------+
minwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
nlwikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+
olowiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
ombudsmenwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
orwikisource
+----------+
| count(*) |
+----------+
|        0 |
+----------+
pawikisource
+----------+
| count(*) |
+----------+
|        0 |
+----------+
plwikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+
pmswikisource
+----------+
| count(*) |
+----------+
|        0 |
+----------+
projectcomwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
pswikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+
ptwikimedia
+----------+
| count(*) |
+----------+
|        0 |
+----------+
ptwikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+
punjabiwikimedia
+----------+
| count(*) |
+----------+
|        0 |
+----------+
romdwikimedia
+----------+
| count(*) |
+----------+
|        0 |
+----------+
rowikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+
ruwikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+
sahwikiquote
+----------+
| count(*) |
+----------+
|        0 |
+----------+
satwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
sawikiquote
+----------+
| count(*) |
+----------+
|        0 |
+----------+
shnwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
svwikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+
tcywiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
techconductwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
testwikidatawiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
transitionteamwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
tyvwiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
ukwikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+
vecwiktionary
+----------+
| count(*) |
+----------+
|        0 |
+----------+
viwikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+
votewiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
wbwikimedia
+----------+
| count(*) |
+----------+
|        0 |
+----------+
wikimania2013wiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
wikimania2014wiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
wikimania2015wiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
wikimania2016wiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
wikimania2017wiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
wikimania2018wiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
wikimaniawiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
yuewiktionary
+----------+
| count(*) |
+----------+
|        0 |
+----------+
zerowiki
+----------+
| count(*) |
+----------+
|        0 |
+----------+
zhwikiversity
+----------+
| count(*) |
+----------+
|        0 |
+----------+
zhwikivoyage
+----------+
| count(*) |
+----------+
|        0 |
+----------+

Also on s4:

#  mysql.py -hdb1081 testcommonswiki -e "select count(*) from globalblocks"
+----------+
| count(*) |
+----------+
|        0 |
+----------+

s5:

#  mysql.py -hdb1070 enwikivoyage -e "select count(*) from globalblocks"
+----------+
| count(*) |
+----------+
|        0 |
+----------+

s8:

n#  mysql.py -hdb1104 wikidatawiki -e "select count(*) from globalblocks"
+----------+
| count(*) |
+----------+
|        0 |
+----------+

Mentioned in SAL (#wikimedia-operations) [2019-08-12T09:24:21Z] <marostegui> Remove empty table testcommonswiki. globalblocks from s4 - T230055

Mentioned in SAL (#wikimedia-operations) [2019-08-12T09:36:04Z] <marostegui> Remove empty table enwikivoyage.globalblocks from s5 - T230055

Mentioned in SAL (#wikimedia-operations) [2019-08-12T10:01:07Z] <marostegui> Remove empty table wikidatawiki.globalblocks from s8 - T230055

Mentioned in SAL (#wikimedia-operations) [2019-08-12T10:09:34Z] <marostegui> Remove empty table globalblocks from s3 (where it exists) - T230055

Marostegui updated the task description. (Show Details)
Marostegui added a subscriber: jcrespo.

All done

The table seems to exist on napwikisource. I wonder if the table is created on install, or was just a one time mistake?

root@db1123[ptwikimedia]> select * FROM information_schema.tables where table_name='globalblocks';
+---------------+---------------+--------------+------------+--------+---------+------------+------------+--------------
| TABLE_CATALOG | TABLE_SCHEMA  | TABLE_NAME   | TABLE_TYPE | ENGINE | VERSION | ROW_FORMAT | TABLE_ROWS | AVG_ROW_LENGT
+---------------+---------------+--------------+------------+--------+---------+------------+------------+--------------
| def           | napwikisource | globalblocks | BASE TABLE | InnoDB |      10 | Compact    |          0 |              
+---------------+---------------+--------------+------------+--------+---------+------------+------------+--------------
1 row in set (0.03 sec)

See also T236015#5639612

jcrespo mentioned this in Unknown Object (Task).Nov 6 2019, 10:17 AM

The table seems to exist on napwikisource. I wonder if the table is created on install, or was just a one time mistake?

root@db1123[ptwikimedia]> select * FROM information_schema.tables where table_name='globalblocks';
+---------------+---------------+--------------+------------+--------+---------+------------+------------+--------------
| TABLE_CATALOG | TABLE_SCHEMA  | TABLE_NAME   | TABLE_TYPE | ENGINE | VERSION | ROW_FORMAT | TABLE_ROWS | AVG_ROW_LENGT
+---------------+---------------+--------------+------------+--------+---------+------------+------------+--------------
| def           | napwikisource | globalblocks | BASE TABLE | InnoDB |      10 | Compact    |          0 |              
+---------------+---------------+--------------+------------+--------+---------+------------+------------+--------------
1 row in set (0.03 sec)

See also T236015#5639612

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikimediaMaintenance/+/471499/ was a couple of weeks after the wiki was created (25th August for the patch being merged, but the wiki was created on the 14th August). So that should be the last wiki with the table, and any future ones shouldn't have it due to the file splitting in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GlobalBlocking/+/471031/

Mentioned in SAL (#wikimedia-operations) [2019-11-11T06:44:20Z] <marostegui> Delete globalblocks table from napwikisource T230055

Thanks for noticing:

root@db1123.eqiad.wmnet[napwikisource]> select count(*) from globalblocks;
+----------+
| count(*) |
+----------+
|        0 |
+----------+
1 row in set (0.00 sec)

root@db1123.eqiad.wmnet[napwikisource]> drop table if exists globalblocks;
Query OK, 0 rows affected (0.10 sec)