Page MenuHomePhabricator

Stop forcing RUNNER=php for foreachwiki/foreachwikiindblist
Closed, ResolvedPublic

Description

According to a conversation @Dzahn and myself held at -releng yesterday related to https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/528730 we've detected that foreachwiki and foreachwikiindblist does force RUNNER=php so it somewhat moots the point of T195392.

I couldn't find much for foreachwiki but foreachwikiindblist does indeed use RUNNER=php on its code: https://github.com/wikimedia/puppet/blob/production/modules/scap/files/foreachwikiindblist

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2019, 9:24 AM
Dzahn added a subscriber: jijiki.Aug 10 2019, 12:38 AM

Here is where i switched that to php7.2 to ensure all crons using foreachwikiindblist are actually using 7.2 and we don't just think it does. (cc: @jijiki )

https://gerrit.wikimedia.org/r/c/operations/puppet/+/528613

@MarcoAurelio Yes, it is in foreachwikiindblist and not in foreachwiki but foreachwiki uses foreachwikiindblist.

also see https://gerrit.wikimedia.org/r/c/operations/puppet/+/425027 though which might or might not make this obsolete

Dzahn added a comment.Tue, Sep 3, 7:10 AM

Kind of, yea. But also we should revert setting it to php7.2 now to avoid hardcoding the version.

Change 534012 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] switch RUNNER in foreachwikiindblist back to just 'php'

https://gerrit.wikimedia.org/r/534012

Change 534012 merged by Dzahn:
[operations/puppet@production] switch RUNNER in foreachwikiindblist back to just 'php'

https://gerrit.wikimedia.org/r/534012

Dzahn closed this task as Resolved.Wed, Sep 4, 4:30 AM
Dzahn claimed this task.