Page MenuHomePhabricator

Stop forcing RUNNER=php for foreachwiki/foreachwikiindblist
Closed, ResolvedPublic


According to a conversation @Dzahn and myself held at -releng yesterday related to we've detected that foreachwiki and foreachwikiindblist does force RUNNER=php so it somewhat moots the point of T195392.

I couldn't find much for foreachwiki but foreachwikiindblist does indeed use RUNNER=php on its code:


Related Gerrit Patches:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2019, 9:24 AM
Dzahn added a subscriber: jijiki.Aug 10 2019, 12:38 AM

Here is where i switched that to php7.2 to ensure all crons using foreachwikiindblist are actually using 7.2 and we don't just think it does. (cc: @jijiki )

@MarcoAurelio Yes, it is in foreachwikiindblist and not in foreachwiki but foreachwiki uses foreachwikiindblist.

also see though which might or might not make this obsolete

CDanis triaged this task as Normal priority.Aug 16 2019, 1:00 PM
Dzahn added a comment.Sep 3 2019, 7:10 AM

Kind of, yea. But also we should revert setting it to php7.2 now to avoid hardcoding the version.

Change 534012 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] switch RUNNER in foreachwikiindblist back to just 'php'

Change 534012 merged by Dzahn:
[operations/puppet@production] switch RUNNER in foreachwikiindblist back to just 'php'

Dzahn closed this task as Resolved.Sep 4 2019, 4:30 AM
Dzahn claimed this task.