Page MenuHomePhabricator

[BUG] Special:Block: Invalid expiration time error message does not appear when there are other validation errors
Open, LowPublicBUG REPORT

Description

What is the problem?

On the Special:Block form, when you enter an invalid expiration time you should see a validation error message (e.g. "Expiry time invalid.").

However, if there are other validation errors on the form as well, it does not appear.

I would also suggest putting the error message below the Expiration input, so it is more obvious and to make it consistent with other validation messages on that form.

Steps to reproduce problem
  1. Go to Special:Block
  2. Under "Expiration" select "Other time" and, in the text input, enter something invalid (Alternatively, click the calendar icon and change the time to be in the past)
  3. Enter some other invalid input (e.g. non-existent user)

Expected behavior: You see an error message saying Expiry time is in the past. or Expiry time invalid. (alongside the other error messages)
Observed behavior: You only see error messages referring to the other invalid input

Screenshots (if applicable):

special_block_expiration_validation_message.png (695×732 px, 35 KB)

Event Timeline

Niharika removed a project: Anti-Harassment.
Niharika subscribed.

If the other validation errors are resolved, the time invalid error shows up. It is only possible to have one error on top and adding an inline error is more work than is worth as it needs to be added to two methods (for the interface and the API.

Leaving this alone for now.