Page MenuHomePhabricator

Install wrk, siege and lua-cjson packages on deploy1001
Closed, ResolvedPublic

Description

We need to do some (light) performance testing of a service deployed to k8s staging, and need the wrk and lua-cjson packages installed.

Event Timeline

Eevans triaged this task as Medium priority.Aug 9 2019, 1:10 AM
Eevans created this task.

Change 529193 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] deployment_server: install benchmarking tools, wrk, siege

https://gerrit.wikimedia.org/r/529193

Change 529193 merged by Dzahn:
[operations/puppet@production] deployment_server: install benchmarking tools, wrk, siege

https://gerrit.wikimedia.org/r/529193

Dzahn closed this task as Resolved.EditedAug 9 2019, 2:09 AM

on deploy1001 and deploy2001:

Notice: /Stage[main]/Packages::Wrk/Package[wrk]/ensure: created
Notice: /Stage[main]/Packages::Lua_cjson/Package[lua-cjson]/ensure: created

on just deploy2001:

Notice: /Stage[main]/Packages::Siege/Package[siege]/ensure: created

Dzahn renamed this task from Install wrk and lua-cjson packages on deploy1001 to Install wrk, siege and lua-cjson packages on deploy1001.Aug 9 2019, 2:10 AM

Looks like we still have the packages installed, if the benchmarking is no more needed maybe they can be removed?

modules/profile/manifests/mediawiki/deployment/server.pp
# benchmarking tools for sessionstorage testing (T230178)
ensure_packages(['siege', 'wrk', 'lua-cjson'])

Looks like we still have the packages installed, if the benchmarking is no more needed maybe they can be removed?

modules/profile/manifests/mediawiki/deployment/server.pp
# benchmarking tools for sessionstorage testing (T230178)
ensure_packages(['siege', 'wrk', 'lua-cjson'])

As far as I am concerned they can be removed.

Change 808052 had a related patch set uploaded (by Dzahn; author: Dzahn):

[operations/puppet@production] deployment_server: remove packages wrk, siege and lua-cjson

https://gerrit.wikimedia.org/r/808052

Change 808052 merged by Dzahn:

[operations/puppet@production] deployment_server: remove packages wrk, siege and lua-cjson

https://gerrit.wikimedia.org/r/808052

Notice: /Stage[main]/Profile::Mediawiki::Deployment::Server/Package[siege]/ensure: removed
Notice: /Stage[main]/Profile::Mediawiki::Deployment::Server/Package[wrk]/ensure: removed
Notice: /Stage[main]/Profile::Mediawiki::Deployment::Server/Package[lua-cjson]/ensure: removed


[cumin2002:~] $ sudo cumin 'C:role::deployment_server' 'run-puppet-agent'

done

Thank you @Eevans and @Dzahn . It is good to see cleanup happening :]

10:10 < elukey> mutante: o/ I found out in https://phabricator.wikimedia.org/T230178 that siege/wrk/etc.. were removed from deploy1002. The host may not have been the right target for the packages, but those are useful in my opinion to do some benchmarks from time to time (my team used them to benchmark our k8s ml infra recently). I am wondering if we could pick up another node, maybe buildXXXX? Not sure if we have

Change 819649 had a related patch set uploaded (by Dzahn; author: Dzahn):

[operations/puppet@production] deployment::server: add comment about usage of benchmarking tools

https://gerrit.wikimedia.org/r/819649

Change 819649 merged by Dzahn:

[operations/puppet@production] deployment::server: add comment about usage of benchmarking tools

https://gerrit.wikimedia.org/r/819649