Page MenuHomePhabricator
Create Task
Maniphest T230219

Complete porting of time tracing code
Closed, ResolvedPublic
Actions

Description

The time tracing utility in Parsoid is quite useful in providing a high level overview of where time is being spent during parsing. That code is only partially enabled. The calls to the time tracing code is probably in place, but the accounting code in Env.php isn't.

We need to finish this pronto.

Details

SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.13.0-a14mediawiki/vendormaster+2 K -1 K
Port time profiling code from Parsoid/JS and adapt it for Parsoid/PHPmediawiki/services/parsoidmaster+1 K -628
Customize query in gerrit

Event Timeline

ssastry created this task.Aug 9 2019, 5:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 9 2019, 5:31 PM
ssastry renamed this task from Finsing out the time tracing and performance metrics part of the code Parsoid/PHP to Complete porting of time tracing and performance metrics.Aug 9 2019, 5:31 PM
ssastry triaged this task as High priority.
ssastry moved this task from Backlog to Performance on the Parsoid-PHP board.
ssastry moved this task from Performance to Porting on the Parsoid-PHP board.Sep 25 2019, 2:06 PM
ssastry renamed this task from Complete porting of time tracing and performance metrics to Complete porting of time tracing code.Oct 18 2019, 5:48 PM
ssastry lowered the priority of this task from High to Medium.
gerritbot added a comment.Oct 18 2019, 5:49 PM

Change 529625 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] WIP: Port time profiling code

https://gerrit.wikimedia.org/r/529625

gerritbot added a project: Patch-For-Review.Oct 18 2019, 5:49 PM
ssastry claimed this task.Oct 18 2019, 5:50 PM
Aklapper edited projects, added Parsoid; removed Parsoid-PHP.Apr 10 2020, 4:27 PM
ssastry moved this task from Needs Triage to Backlog on the Parsoid board.Apr 10 2020, 4:57 PM
ssastry moved this task from Backlog to Missing Functionality on the Parsoid board.May 1 2020, 4:27 PM
ssastry added a project: Parsing-Active-Work.Oct 1 2020, 5:03 PM
ssastry moved this task from Incoming Work (but not yet ready) to Doing (Roadmap Critical Path) on the Parsing-Active-Work board.
gerritbot added a comment.Oct 27 2020, 3:46 PM

Change 529625 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Port time profiling code from Parsoid/JS and adapt it for Parsoid/PHP

https://gerrit.wikimedia.org/r/529625

ssastry closed this task as Resolved.Oct 27 2020, 3:49 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 27 2020, 4:11 PM
gerritbot added a comment.Nov 2 2020, 7:14 PM

Change 638161 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a14

https://gerrit.wikimedia.org/r/638161

gerritbot added a project: Patch-For-Review.Nov 2 2020, 7:14 PM
gerritbot added a comment.Nov 2 2020, 9:30 PM

Change 638161 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.13.0-a14

https://gerrit.wikimedia.org/r/638161

Maintenance_bot removed a project: Patch-For-Review.Nov 2 2020, 10:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits