Page MenuHomePhabricator

Scroll animation when loading the visual editor no longer scrolls to the right place
Closed, ResolvedPublic

Description

Scroll animation when loading the visual editor no longer scrolls to the right place.

It's supposed to scroll so that the clicked heading in view mode aligns with its position at the top of the window in edit mode, but it doesn't.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 529424 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] mobile.init/editor: Fix the scrolling animation after Minerva changes

https://gerrit.wikimedia.org/r/529424

For comparison, expected behavior after the fix:

Change 529424 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] mobile.init/editor: Fix the scrolling animation after Minerva changes

https://gerrit.wikimedia.org/r/529424

This seems to be not yet fixed on Beta, assuming it's about the alignment of the heading before it completes loading the editor?

@Ryasmeen I think that's a separate issue, probably the same as Ed reported in T230552.

I slowed down your recording and took a few screenshots:

Initial content (read mode)After scrolling – this is correct now and previously was wrongSuddenly the initial read mode content flashesAfter loading the editor

The second screenshot shows that this bug is fixed (it is the same as fourth screenshot… or close enough). The third screenshot is unexpected but I'd rather look at that later in T230552.

@Ryasmeen I think that's a separate issue, probably the same as Ed reported in T230552.

I slowed down your recording and took a few screenshots:

Initial content (read mode)After scrolling – this is correct now and previously was wrongSuddenly the initial read mode content flashesAfter loading the editor

The second screenshot shows that this bug is fixed (it is the same as fourth screenshot… or close enough). The third screenshot is unexpected but I'd rather look at that later in T230552.

Sounds good @matmarex. Closing this in that case.