Page MenuHomePhabricator

Create custom explanation for lacking user rights
Closed, ResolvedPublic

Description

Once $wgUrlShortenerReadOnly to deactivated, users will only be prevented from creating short urls on non-meta wikis because they lack the user rights needed. Currently, the message that would be shown is the default PermissionsError based on the lack of rights, and the api will only return the apierror-permissiondenied message. Instead, UrlShortener should introduce two new messages (for the special page and the api) that serve the same function (explaining the lack of user rights) but that can be overridden with wikimedia messages to explain that meta should be used.

I propose the following keys: urlshortener-badaccessgroups and apierror-urlshortener-permissiondenied

Event Timeline

Change 529463 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/UrlShortener@master] Add custom messages for lacking rights to create short urls

https://gerrit.wikimedia.org/r/529463

Change 529463 merged by jenkins-bot:
[mediawiki/extensions/UrlShortener@master] Add custom messages for lacking rights to create short urls

https://gerrit.wikimedia.org/r/529463

Change 558766 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaMessages@master] Override custom messages for lacking rights to create short urls

https://gerrit.wikimedia.org/r/558766

Change 558766 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] Override custom messages for lacking rights to create short urls

https://gerrit.wikimedia.org/r/558766

Change 567408 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/UrlShortener@master] Check user rights before $wgUrlShortenerReadOnly

https://gerrit.wikimedia.org/r/567408

Change 567408 merged by jenkins-bot:
[mediawiki/extensions/UrlShortener@master] Check user rights before $wgUrlShortenerReadOnly

https://gerrit.wikimedia.org/r/567408