Page MenuHomePhabricator
Create Task
Maniphest T230267

Long link descriptions abruptly truncated in link context
Closed, ResolvedPublic
Actions

Description

image.png (171×417 px, 16 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (c2c5149f3)mediawiki/extensions/VisualEditormaster+4 -8
LinkContextItem: Apply ellipsis directly to linkVisualEditor/VisualEditormaster+6 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Aug 10 2019, 1:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2019, 1:30 PM
Esanders renamed this task from Long link descriptions not truncated in link context to Long link descriptions abruptly truncated in link context.Aug 10 2019, 1:43 PM
Esanders added a project: Regression.
Esanders updated the task description. (Show Details)
gerritbot added a comment.Aug 10 2019, 1:54 PM

Change 529467 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Apply ellipsis directly to link

https://gerrit.wikimedia.org/r/529467

gerritbot added a project: Patch-For-Review.Aug 10 2019, 1:54 PM
Esanders added a comment.Aug 10 2019, 1:54 PM

Before this regression we just let the text wrap:

image.png (180×424 px, 18 KB)

gerritbot added a comment.Aug 10 2019, 1:56 PM

Change 529468 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] [PULL THROUGH] Fix link ellipsis styles

https://gerrit.wikimedia.org/r/529468

Esanders claimed this task.Aug 10 2019, 3:19 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Aug 15 2019, 8:11 AM

Change 529467 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] LinkContextItem: Apply ellipsis directly to link

https://gerrit.wikimedia.org/r/529467

gerritbot added a comment.Aug 15 2019, 8:36 AM

Change 529468 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c2c5149f3)

https://gerrit.wikimedia.org/r/529468

Maintenance_bot removed a project: Patch-For-Review.Aug 15 2019, 9:10 AM
matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Aug 19 2019, 2:38 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 20 2019, 8:01 PM
matmarex added a project: Editing QA.Aug 21 2019, 4:07 PM
matmarex merged a task: T230493: Fix link label ellipses on iOS.Aug 23 2019, 1:30 AM
matmarex updated the task description. (Show Details)
matmarex added a parent task: T229831: Implement Edit Cards v3.
matmarex added a subscriber: ppelberg.
Esanders mentioned this in T230493: Fix link label ellipses on iOS.Aug 26 2019, 11:03 PM
Esanders updated the task description. (Show Details)
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.Sep 5 2019, 8:16 PM
Ryasmeen edited projects, added Verified; removed Editing QA.
ppelberg closed this task as Resolved.Sep 20 2019, 11:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits