Page MenuHomePhabricator

Google AppEngine CloudSQL Unix socket connection name contains colons not expected by MediaWiki (e.g. localhost:/cloudsql/project:region:database)
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

Deploy MediaWiki to Google AppEngine

Actual Results:

mw-config fails, cannot connect to database when Unix socket provided by AppEngine (/cloudsql path) is used to connect to a Google Cloud SQL database instance.

Expected Results:

unfail

Event Timeline

Change 529627 had a related patch set uploaded (by RiskNerd; owner: RiskNerd):
[mediawiki/core@master] core: Fix detecting Unix domain socket to connect database on Google AppEngine

https://gerrit.wikimedia.org/r/529627

Fixed and published for review. The number of colons expected for a Unix socket must be >= 1 instead of == 1.

https://gerrit.wikimedia.org/r/529627

Aklapper added a project: Wikimedia-Rdbms.

Hi @RiskNerd, thanks for taking the time to report this and providing a patch (and welcome to Wikimedia Phabricator)!

I'm reopening this task as code has been proposed in Gerrit, but not yet merged.

mobrovac added a subscriber: mobrovac.

Thank you, @RiskNerd for reporting, investigating and fixing the bug :)

Change 529627 merged by jenkins-bot:
[mediawiki/core@master] MySQL connect: Parse the Unix domain socket path correctly

https://gerrit.wikimedia.org/r/529627