Page MenuHomePhabricator

Google AppEngine CloudSQL Unix socket connection name contains colons not expected by MediaWiki (e.g. localhost:/cloudsql/project:region:database)
Closed, ResolvedPublicBug

Description

Steps to Reproduce:

Deploy MediaWiki to Google AppEngine

Actual Results:

mw-config fails, cannot connect to database when Unix socket provided by AppEngine (/cloudsql path) is used to connect to a Google Cloud SQL database instance.

Expected Results:

unfail

Event Timeline

RiskNerd created this task.Mon, Aug 12, 3:01 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, Aug 12, 3:01 AM

Change 529627 had a related patch set uploaded (by RiskNerd; owner: RiskNerd):
[mediawiki/core@master] core: Fix detecting Unix domain socket to connect database on Google AppEngine

https://gerrit.wikimedia.org/r/529627

RiskNerd closed this task as Resolved.Mon, Aug 12, 5:19 AM

Fixed and published for review. The number of colons expected for a Unix socket must be >= 1 instead of == 1.

https://gerrit.wikimedia.org/r/529627

Aklapper reopened this task as Open.Mon, Aug 12, 10:24 AM
Aklapper added a project: Mediawiki-Rdbms.

Hi @RiskNerd, thanks for taking the time to report this and providing a patch (and welcome to Wikimedia Phabricator)!

I'm reopening this task as code has been proposed in Gerrit, but not yet merged.

Restricted Application added a project: Core Platform Team. · View Herald TranscriptMon, Aug 12, 10:24 AM
mobrovac closed this task as Resolved.Mon, Aug 19, 10:29 AM
mobrovac added a subscriber: mobrovac.

Thank you, @RiskNerd for reporting, investigating and fixing the bug :)

Change 529627 merged by jenkins-bot:
[mediawiki/core@master] MySQL connect: Parse the Unix domain socket path correctly

https://gerrit.wikimedia.org/r/529627