Error: 1146 Table 'valid_tag' doesn't exist when upgrading from an ancient MediaWiki version
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ciencia_Al_Poder
	Aug 12 2019, 9:39 AM

Description

When upgrading from an ancient MediaWiki version (1.12) the update.php script fails with the error:

An error occurred:
A database query error has occurred. Did you forget to run your application's database schema updater after upgrading?
Query: SELECT  vt_tag AS `value`  FROM `valid_tag`     
Function: PopulateChangeTagDef::setUserDefinedTags
Error: 1146 Table 'wikidb.valid_tag' doesn't exist (localhost)

The valid_tag table was added in 1.15 and removed in 1.33: https://www.mediawiki.org/wiki/Manual:Valid_tag_table

Apparently, a script is running to migrate the data from that table to other tables before removing it, but that table doesn't exist in the first place. This means installations upgrading from a version before 1.15 will fail.

Reports of this error in the Support Desk:

Details

	Subject	Repo	Branch	Lines +/-
	maintenance/populateChangeTagDef.php: Handle missing valid_tags table	mediawiki/core	REL1_33	+11 -6
	maintenance/populateChangeTagDef.php: Handle missing valid_tags table	mediawiki/core	master	+9 -6

Customize query in gerrit

Related Objects

Mentioned In: T259771: RFC: Drop support for older database upgrades
T205094: Investigate and restructure SQL directory, and use new MediaWiki abstract schema change features
T209525: Migrate tag_summary usage to change_tag and drop the table

Event Timeline

Ciencia_Al_Poder created this task.Aug 12 2019, 9:39 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 12 2019, 9:39 AM

Ciencia_Al_Poder renamed this task from Error: 1146 Table 'wikidb.valid_tag' doesn't exist when upgrading from an ancient MediaWiki version to Error: 1146 Table 'valid_tag' doesn't exist when upgrading from an ancient MediaWiki version.Aug 12 2019, 9:40 AM

Ciencia_Al_Poder mentioned this in T209525: Migrate tag_summary usage to change_tag and drop the table.Aug 12 2019, 9:44 AM

Ciencia_Al_Poder moved this task from Backlog to update.php on the MediaWiki-Maintenance-system board.

Marostegui added a subscriber: Ladsgroup.Aug 12 2019, 9:45 AM

1.12 was released in February 2009, more than 10 years ago. Upgrading in one go from that version to 1.33 is bound to have issues. You can upgrade from 1.12 to 1.16 first and then upgrade to 1.33. That would fix this issue.

Also easy enough to work around, though.

Change 530173 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] maintenance/populateChangeTagDef.php: Handle missing valid_tags table

https://gerrit.wikimedia.org/r/530173

gerritbot added a project: Patch-For-Review.Aug 14 2019, 3:59 PM

Anomie moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Aug 14 2019, 3:59 PM

Change 530173 merged by jenkins-bot:
[mediawiki/core@master] maintenance/populateChangeTagDef.php: Handle missing valid_tags table

https://gerrit.wikimedia.org/r/530173

Anomie closed this task as Resolved.Aug 14 2019, 7:29 PM

Anomie claimed this task.

Anomie moved this task from Waiting for Review to Done on the Platform Team Workboards (Clinic Duty Team) board.

Maintenance_bot removed a project: Patch-For-Review.Aug 14 2019, 8:10 PM

Change 530325 had a related patch set uploaded (by Jforrester; owner: Anomie):
[mediawiki/core@REL1_33] maintenance/populateChangeTagDef.php: Handle missing valid_tags table

https://gerrit.wikimedia.org/r/530325

gerritbot added a project: Patch-For-Review.Aug 15 2019, 7:18 AM

Change 530325 merged by jenkins-bot:
[mediawiki/core@REL1_33] maintenance/populateChangeTagDef.php: Handle missing valid_tags table

https://gerrit.wikimedia.org/r/530325

Maintenance_bot removed a project: Patch-For-Review.Aug 15 2019, 8:11 AM

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 20 2019, 7:02 PM

ReleaseTaggerBot added a project: MW-1.33-notes.Aug 20 2019, 8:01 PM

Ladsgroup mentioned this in T205094: Investigate and restructure SQL directory, and use new MediaWiki abstract schema change features.Aug 5 2020, 11:40 PM

Ladsgroup mentioned this in T259771: RFC: Drop support for older database upgrades.Aug 6 2020, 1:49 AM

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:43 PM