Homepage: user info text vertical stacking issues in mobile account creation module
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	• Cntlsn
	Aug 12 2019, 2:51 PM

Description

In the mobile account creation module, user info text styling is not consistent with mockup specifications.

Actual Results:

Screenshot 2019-08-06 13.39.19.png (474×752 px, 48 KB)

Expected Results:

Screenshot 2019-08-12 16.47.40.png (352×750 px, 36 KB)

.growthexperiments-homepage-module-start.growthexperiments-homepage-module-mobile-overlay > .growthexperiments-homepage-module-section-body .growthexperiments-homepage-module-start-account .growthexperiments-homepage-module-section-userinfo {
  margin-bottom: 1em;
}

.growthexperiments-homepage-module-start > .growthexperiments-homepage-module-body .growthexperiments-homepage-module-start-account .growthexperiments-homepage-module-section-userinfo .growthexperiments-homepage-module-section-username {
  line-height: 1em;
}

Details

	Subject	Repo	Branch	Lines +/-
	Start/Account: add padding to username to align with icon	mediawiki/extensions/GrowthExperiments	master	+1 -0
	Start/Account: update text size and position	mediawiki/extensions/GrowthExperiments	master	+17 -6

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		• Rileych	T213990 [EPIC] Growth: Newcomer homepage
Resolved		MMiller_WMF	T215983 Homepage: mobile version
Resolved		• Rileych	T230014 Homepage: layout and UI fixes
Resolved	BUG REPORT	SBisson	T230350 Homepage: user info text vertical stacking issues in mobile account creation module

Event Timeline

• Cntlsn created this task.Aug 12 2019, 2:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 12 2019, 2:51 PM

• Cntlsn triaged this task as Medium priority.Aug 12 2019, 2:51 PM

• Cntlsn moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

• Cntlsn added parent tasks: T215983: Homepage: mobile version, T230014: Homepage: layout and UI fixes.Aug 12 2019, 5:49 PM

phuedx moved this task from Needs triage to Growth on the Mobile board.Aug 15 2019, 11:11 AM

Change 530590 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Start/Account: update text size and position

https://gerrit.wikimedia.org/r/530590

gerritbot added a project: Patch-For-Review.Aug 16 2019, 3:10 PM

SBisson claimed this task.Aug 16 2019, 3:10 PM

SBisson moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 16 2019, 8:05 PM

Change 530590 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Start/Account: update text size and position

https://gerrit.wikimedia.org/r/530590

Maintenance_bot removed a project: Patch-For-Review.Aug 16 2019, 9:11 PM

The specs seem to be in place:

betalabs	testwiki

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.20; 2019-08-27).Aug 20 2019, 9:01 PM

Hi @SBisson - can we add a super minor change so the text is vertically center-aligned?

The change is to add padding-top:.15em to the username class:

Change 531493 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Start/Account: add padding to username to align with icon

https://gerrit.wikimedia.org/r/531493

gerritbot added a project: Patch-For-Review.Aug 21 2019, 1:55 PM

In T230350#5428281, @RHo wrote:

Hi @SBisson - can we add a super minor change so the text is vertically center-aligned?
The change is to add padding-top:.15em to the username class:

Done in the patch above.

Change 531493 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Start/Account: add padding to username to align with icon

https://gerrit.wikimedia.org/r/531493

Maintenance_bot removed a project: Patch-For-Review.Aug 21 2019, 11:10 PM

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 22 2019, 6:09 AM

(1) the text is vertically center-aligned

Screen Shot 2019-08-22 at 3.20.18 PM.png (201×445 px, 22 KB)

(2) The has been made according to the specs (the screenshot scale is 120%) :

In T230350#5428281, @RHo wrote:

The change is to add padding-top:.15em to the username class:

Screen Shot 2019-08-22 at 3.25.56 PM.png (338×424 px, 29 KB)

thanks, LGTM

Thank you!

	F30068981: Screen Shot 2019-08-22 at 3.20.18 PM.png
	Aug 22 2019, 10:35 PM

	F30069118: Screen Shot 2019-08-22 at 3.26.32 PM.png
	Aug 22 2019, 10:35 PM

	F30069070: Screen Shot 2019-08-22 at 3.25.56 PM.png
	Aug 22 2019, 10:35 PM

	F30048379: Screen Shot 2019-08-19 at 4.14.50 PM.png
	Aug 19 2019, 11:16 PM

	F30052304: image.png
	Aug 21 2019, 12:27 PM

	F30052300: image.png
	Aug 21 2019, 12:27 PM

Homepage: user info text vertical stacking issues in mobile account creation moduleClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related ObjectsSearch...

Event Timeline

Homepage: user info text vertical stacking issues in mobile account creation module
Closed, ResolvedPublicBUG REPORT
Actions

Related Objects
Search...