Page MenuHomePhabricator

Homepage: modules padding issues in mobile Start module dialog
Closed, ResolvedPublicBUG REPORT


According to mockup specifications, modules in the mobile Start module details dialog should have larger top and bottom padding.

Actual Results:

Screenshot 2019-08-07 11.57.01.png (416×750 px, 38 KB)

Expected Results:

Screenshot 2019-08-12 17.57.40.png (368×640 px, 29 KB)

.growthexperiments-homepage-module-start.growthexperiments-homepage-module-mobile-overlay > .growthexperiments-homepage-module-section-body .growthexperiments-homepage-module {
  padding: 1em 0 1.85em 0;

Event Timeline

Change 530592 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Start: increase submodules padding

Change 530592 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Start: increase submodules padding

The specs seem to be in place:

Screen Shot 2019-08-19 at 3.55.54 PM.png (890×445 px, 71 KB)
Screen Shot 2019-08-19 at 3.56.02 PM.png (884×430 px, 76 KB)