Page MenuHomePhabricator

GettextFFS should ignore fuzzy header for translation files
Closed, ResolvedPublic

Description

The incident reported in https://translatewiki.net/wiki/Thread:Support/FuzzyBot_copy-pasting_English_lines_to_Danish could be avoided if GettextFFS would ignore fuzzy headers (that it uses to determine whether to read msgid instead of msgstr) would be ignored for translation files.

Outcome

We improved Gettext file format parsing code to avoid situations where source language strings would incorrectly be imported as translations.

Event Timeline

Change 697422 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] GettextFFS: Only allow pot mode for source language

https://gerrit.wikimedia.org/r/697422

Change 697422 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] GettextFFS: Only allow pot mode for source language

https://gerrit.wikimedia.org/r/697422

This was deployed and QAd in translatewiki.net