Page MenuHomePhabricator

Homepage: margin issues with light text in mobile Impact module dialog
Closed, ResolvedPublicBUG REPORT

Description

In the context of the mobile Newcomer homepage, the light text preceding the list of recent edits in the mobile Impact module details dialog features wrong margins.

Actual Results:

Screenshot 2019-08-06 17.41.07.png (450×750 px, 57 KB)

Expected Results:

Screenshot 2019-08-12 18.37.42.png (300×750 px, 51 KB)

.growthexperiments-homepage-module-impact p {
    margin: 1em 0 0.5em 0;
}

Event Timeline

Change 530599 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Impact: update margin of <p>

https://gerrit.wikimedia.org/r/530599

Change 530599 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Impact: update margin of <p>

https://gerrit.wikimedia.org/r/530599

Checked in betalabs - all seems to be in place:

betalabstestwiki
Screen Shot 2019-08-19 at 2.05.16 PM.png (992×1 px, 364 KB)
Screen Shot 2019-08-19 at 2.05.39 PM.png (1×1 px, 400 KB)