| • Cntlsn | |
| Aug 12 2019, 5:05 PM |
| F30077798: Screen Shot 2019-08-23 at 11.17.09 AM.png | |
| Aug 23 2019, 6:17 PM |
| F30043124: mentor_last_active.PNG | |
| Aug 17 2019, 1:06 AM |
| F30009117: Screenshot 2019-08-06 17.57.45.png | |
| Aug 12 2019, 5:05 PM |
| F30009120: Screenshot 2019-08-12 19.02.51.png | |
| Aug 12 2019, 5:05 PM |
In the context of the mobile Newcomer homepage, mentor info text in the Mentorship module dialog has styling issues.
Actual Results:
letter-spacing is 0.02em
Expected Results:
letter-spacing should be 0
.growthexperiments-homepage-mentorship-editcount, .growthexperiments-homepage-mentorship-lastactive {
letter-spacing: 0;
}| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Rileych | T213990 [EPIC] Growth: Newcomer homepage | |||
| Resolved | MMiller_WMF | T215983 Homepage: mobile version | |||
| Resolved | • Rileych | T230014 Homepage: layout and UI fixes | |||
| Resolved | BUG REPORT | SBisson | T230373 Homepage: mentor text style issues in mobile Mentorship module dialog |
There's a letter-spacing: 0.02em rule on these because you asked for it here: T218966#5130398
Should the increased letter spacing continue to be applied on desktop, and only be undone on mobile, or should it be removed completely?
Change 530581 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Mentorship: update mentor edit count and last active text
Change 530581 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Mentorship: update mentor edit count and last active text
Hi @SBisson @Catrope - can we remove letter-spacing from all the modules please? It has very marginal benefit considering we are using the standard sans-serif font stack anyway, and in the different languages we have the module, I prefer to not change the letter-spacing from the default of 0 in case of unintended visual effects.
Change 531495 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Use only default letter spacing
Change 531495 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Use only default letter spacing
