Page MenuHomePhabricator

Adjust the save button of the Entity Schema editor
Closed, ResolvedPublic3 Story Points

Description

The save button of the edit form of Entity Schema says "Submit", which is different from other Mediawiki text editors, which say "Publish changes" or "Save changes"
Also, the button does not have a keyboard shortcut defined, unlike the respective buttons in other forms.

Acceptance criteria:

  • The label of the button says "Publish changes" (publishchanges i18n message) or "Save changes" (savechanges i18n message) according to MediaWiki's EditSubmitButtonLabelPublish setting.
  • The button has an accesskey="s" attribute set.

Details

Related Gerrit Patches:
mediawiki/extensions/EntitySchema : masterAdjust the save button of the Entity Schema editor

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2019, 9:39 AM
WMDE-leszek updated the task description. (Show Details)Aug 13 2019, 12:15 PM
alaa_wmde set the point value for this task to 3.Aug 13 2019, 12:16 PM
alaa_wmde moved this task from Ready to estimate to Ready to pick up on the Wikidata-Campsite board.

Change 531461 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/EntitySchema@master] Adjust the save button of the Entity Schema editor

https://gerrit.wikimedia.org/r/531461

Change 531461 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] Adjust the save button of the Entity Schema editor

https://gerrit.wikimedia.org/r/531461