Page MenuHomePhabricator
Create Task
Maniphest T230446

Create composer-test-php70 docker image for fundraising tech's crm tests
Closed, ResolvedPublic
Actions

Description

Hi Releng folks. If it's not too much work, could you please create a docker image capable of running our CiviCRM tests on PHP7.0? We will very likely be running 7.0 in production till the end of December at least.

We are also updating dependencies so the PHP5.6 tests no longer work (see https://gerrit.wikimedia.org/r/526573 for example). There's supposed to be a set of tests running on PHP7.2, but they're failing because of a missing php-intl extension (see https://gerrit.wikimedia.org/r/518742). It would be nice to get those working, but even nicer to get a testing environment with the same version of PHP as we're using in production.

Details

SubjectRepoBranchLines +/-
layout: [wikimedia/fundraising/crm] Make …-composer-php70-docker a full jobintegration/configmaster+2 -2
jjb: Use subsidiary images changed by move to versioned PHP imagesintegration/configmaster+11 -11
dockerfiles: Rename php to php70 and add intlintegration/configmaster+38 -1
dockerfiles: Bump things over to use php70 which adds intlintegration/configmaster+209 -3
layout: [wikimedia/fundraising/crm] Add …-composer-php70-docker as experimentalintegration/configmaster+2 -0
jjb: Provide wikimedia-fundraising-crm-composer-php70-dockerintegration/configmaster+2 -0
Customize query in gerrit

Event Timeline

Ejegg created this task.Aug 13 2019, 7:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2019, 7:34 PM
Ejegg added subscribers: zeljkofilipin, thcipriani.Aug 19 2019, 3:28 PM
• DStrine moved this task from Triage to Blocked or not fr-tech on the Fundraising-Backlog board.Aug 19 2019, 7:37 PM
greg edited projects, added Continuous-Integration-Infrastructure, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO; removed Release-Engineering-Team.Aug 26 2019, 5:52 AM
greg moved this task from Should be empty (use Release-Engineering-Team) to Next on the Release-Engineering-Team-TODO board.
Jdforrester-WMF subscribed.Oct 2 2019, 5:28 PM

Hey, happy to help out.

Just to confirm, you want 7.0 not 7.2? Everything else in production is now running 7.2.

Jdforrester-WMF edited projects, added Release-Engineering-Team-TODO (201910); removed Release-Engineering-Team-TODO.Oct 2 2019, 5:31 PM
Jdforrester-WMF claimed this task.Oct 2 2019, 6:21 PM
Ejegg added a comment.Oct 3 2019, 12:53 AM

Yep, the payments cluster, including our CiviCRM box, is stuck on 7.0 till at least the end of the year.

zeljkofilipin unsubscribed.Oct 3 2019, 9:33 AM
gerritbot added a comment.Oct 3 2019, 7:07 PM

Change 540662 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] jjb: Provide wikimedia-fundraising-crm-composer-php70-docker

https://gerrit.wikimedia.org/r/540662

gerritbot added a project: Patch-For-Review.Oct 3 2019, 7:07 PM

Change 540663 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: [wikimedia/fundraising/crm] Add …-composer-php70-docker as experimental

https://gerrit.wikimedia.org/r/540663

gerritbot added a comment.Oct 3 2019, 7:10 PM

Change 540662 merged by jenkins-bot:
[integration/config@master] jjb: Provide wikimedia-fundraising-crm-composer-php70-docker

https://gerrit.wikimedia.org/r/540662

gerritbot added a comment.Oct 3 2019, 7:12 PM

Change 540663 merged by jenkins-bot:
[integration/config@master] layout: [wikimedia/fundraising/crm] Add …-composer-php70-docker as experimental

https://gerrit.wikimedia.org/r/540663

Stashbot added a comment.Oct 3 2019, 7:12 PM

Mentioned in SAL (#wikimedia-releng) [2019-10-03T19:12:51Z] <James_F> [wikimedia/fundraising/crm] AAdd experimental php70 job T230446

Maintenance_bot removed a project: Patch-For-Review.Oct 3 2019, 8:10 PM
gerritbot added a comment.Oct 3 2019, 8:39 PM

Change 540664 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: [wikimedia/fundraising/crm] Make …-composer-php70-docker a full job

https://gerrit.wikimedia.org/r/540664

gerritbot added a project: Patch-For-Review.Oct 3 2019, 8:39 PM

Change 540681 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] dockerfiles: Rename php to php70 and add intl

https://gerrit.wikimedia.org/r/540681

gerritbot added a comment.Oct 3 2019, 8:39 PM

Change 540682 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] dockerfiles: Bump things over to use php70 which adds intl

https://gerrit.wikimedia.org/r/540682

gerritbot added a comment.Oct 3 2019, 8:39 PM

Change 540683 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] jjb: Move jobs over to php70-inherited images

https://gerrit.wikimedia.org/r/540683

gerritbot added a comment.Oct 3 2019, 8:56 PM

Change 540681 merged by jenkins-bot:
[integration/config@master] dockerfiles: Rename php to php70 and add intl

https://gerrit.wikimedia.org/r/540681

gerritbot added a comment.Oct 3 2019, 9:01 PM

Change 540682 merged by jenkins-bot:
[integration/config@master] dockerfiles: Bump things over to use php70 which adds intl

https://gerrit.wikimedia.org/r/540682

Jdforrester-WMF moved this task from INBOX to Doing on the Release-Engineering-Team-TODO (201910) board.Oct 10 2019, 7:36 PM
Ejegg added a comment.Oct 15 2019, 3:33 PM

Thanks @Jdforrester-WMF , looks like this is working great!

Jdforrester-WMF added a comment.Oct 17 2019, 8:55 PM
In T230446#5575751, @Ejegg wrote:

Thanks @Jdforrester-WMF , looks like this is working great!

Hey, thanks. Happy to help out.

Unfortunately I can't switch it on in a voting manner right now because one of your dependencies (via civicrm) is using String as a class name, which is prohibited in PHP 7.0. See https://integration.wikimedia.org/ci/job/wikimedia-fundraising-crm-composer-php70-docker/4/console

What do you want me to do next? I could make it run alongside the PHP 7.2 test as non-voting?

Jdforrester-WMF changed the task status from Open to Stalled.Oct 17 2019, 8:55 PM
gerritbot added a comment.Oct 17 2019, 9:18 PM

Change 540683 merged by jenkins-bot:
[integration/config@master] jjb: Use subsidiary images changed by move to versioned PHP images

https://gerrit.wikimedia.org/r/540683

Ejegg added a comment.Oct 18 2019, 4:00 PM

Oh shoot, thanks for pointing that out. The CSS library with the offending class name seems to have since been updated to call the class CSSString. I'll try to get the new version in, once I can figure out how to test it. It's not referred to directly in the CiviCRM codebase - it's a dependency of a SVG library which in turn is a dependency of a PDF library.

Jdforrester-WMF added a comment.Oct 18 2019, 7:53 PM

Yeah, dependency hell. My sympathies, especially at this time of year. :-(

Jdforrester-WMF moved this task from Doing to Done (within RelEng) on the Release-Engineering-Team-TODO (201910) board.Oct 23 2019, 10:47 AM
Jdforrester-WMF edited projects, added Release-Engineering-Team-TODO; removed Release-Engineering-Team-TODO (201910).Nov 1 2019, 2:39 AM
Jdforrester-WMF moved this task from Untriaged to Externally Blocked on the Continuous-Integration-Infrastructure board.
Jdforrester-WMF triaged this task as Medium priority.Dec 17 2019, 11:23 AM
gerritbot added a comment.Aug 13 2020, 9:42 AM

Change 540664 abandoned by Jforrester:
[integration/config@master] layout: [wikimedia/fundraising/crm] Make …-composer-php70-docker a full job

Reason:
This didn't go anywhere.

https://gerrit.wikimedia.org/r/540664

thcipriani removed a project: Release-Engineering-Team (CI & Testing services).Apr 20 2021, 1:09 AM
thcipriani edited projects, added Release-Engineering-Team (thcipriani-workboard-fiddling); removed Release-Engineering-Team-TODO.Apr 20 2021, 3:29 AM
thcipriani moved this task from thcipriani-workboard-fiddling to Next (ARCHIVED) on the Release-Engineering-Team board.Apr 20 2021, 3:30 AM
thcipriani edited projects, added Release-Engineering-Team; removed Release-Engineering-Team (thcipriani-workboard-fiddling).
thcipriani edited projects, added Release-Engineering-Team (Next); removed Release-Engineering-Team.Apr 20 2021, 3:18 PM
Jdforrester-WMF removed Jdforrester-WMF as the assignee of this task.Aug 12 2021, 5:09 PM
thcipriani edited projects, added Release-Engineering-Team (Priority Backlog 📥); removed Release-Engineering-Team (Next).Sep 7 2022, 3:46 PM
Pppery removed a project: Patch-For-Review.Apr 2 2023, 1:13 AM
hashar closed this task as Resolved.Fri, Mar 29, 8:21 AM
hashar claimed this task.
hashar subscribed.

This is what we have today:

zuul/layout.yaml
- name: wikimedia/fundraising/crm
  template:
    - name: composer-test-php74-only
  test:
    - wikimedia-fundraising-civicrm-bullseye-docker
  gate-and-submit:
    - wikimedia-fundraising-civicrm-bullseye-docker

The wikimedia-fundraising-civicrm-bullseye-docker job uses the Docker image docker-registry.wikimedia.org/releng/docker-registry.wikimedia.org/releng/civicrm:0.4.2-s2. That image is based on Debian Bullseye and install its php package. If needed, we can move it to Bookworm.

:-]

hashar removed hashar as the assignee of this task.Fri, Mar 29, 8:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL